fixer: Prep for 1.0 tests #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
anderseknert
approved these changes
Jan 8, 2025
pkg/fixer/fixer_test.go
Outdated
| } | ||
|
|
||
| deny = true | ||
| allow = true #no space |
There was a problem hiding this comment.
didn’t it used to be that way before because the formatter would rewrite it to
allow = true
and we wanted to make sure we didn’t have that in our output?
There was a problem hiding this comment.
Hmm, originally I didn't want to have the complicated formatting logic in these tests, but I think it's fine and have reverted this in b174300.
pkg/fixer/fixer_test.go
Outdated
| []fixes.Fix{ | ||
| &fixes.UseAssignmentOperator{}, | ||
| &fixes.NoWhitespaceComment{}, | ||
| &fixes.DirectoryPackageMismatch{}, |
There was a problem hiding this comment.
So we don't want formatting here?
| @@ -14,10 +13,9 @@ func NewDefaultFixes() []Fix { | |||
| return []Fix{ | |||
| &Fmt{}, | |||
| &Fmt{ | |||
| // this effectively maps the fix for violations from the | |||
| // use-rego-v1 rule to just format the file. | |||
charlieegan3
force-pushed
the
fixer-tests
branch
from
b174300 to
deccb93
Compare
anderseknert
approved these changes
Jan 8, 2025
Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
fixer-tests
branch
from
deccb93 to
a5c1b18
Compare
anderseknert
pushed a commit
that referenced
this pull request
Jan 8, 2025
* fixer: Prep for 1.0 tests Signed-off-by: Charlie Egan <[email protected]> * fixer/fmt: Add tests for other rego versions Signed-off-by: Charlie Egan <[email protected]> * fixer: Update fixer e2e test Signed-off-by: Charlie Egan <[email protected]> * Correct formatting of launch.json * fixer: Return formatting to Fixer test Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
that referenced
this pull request
Jan 9, 2025
* fixer: Prep for 1.0 tests Signed-off-by: Charlie Egan <[email protected]> * fixer/fmt: Add tests for other rego versions Signed-off-by: Charlie Egan <[email protected]> * fixer: Update fixer e2e test Signed-off-by: Charlie Egan <[email protected]> * Correct formatting of launch.json * fixer: Return formatting to Fixer test Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
anderseknert
pushed a commit
that referenced
this pull request
Jan 13, 2025
* fixer: Prep for 1.0 tests Signed-off-by: Charlie Egan <[email protected]> * fixer/fmt: Add tests for other rego versions Signed-off-by: Charlie Egan <[email protected]> * fixer: Update fixer e2e test Signed-off-by: Charlie Egan <[email protected]> * Correct formatting of launch.json * fixer: Return formatting to Fixer test Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.