-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp: Auto update examples index #956
Conversation
4782af9
to
7bd0b16
Compare
5ac2e32
to
1b23fa2
Compare
"contains": "keywords/contains", | ||
"some": "keywords/some" | ||
} | ||
"builtins": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here will be updated when the workflow is manually run on main, or on schedule.
1b23fa2
to
78b8350
Compare
78b8350
to
1d09493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor remarks, but looks good!
|
||
- name: Install xq (part of yq) | ||
run: | | ||
pip install yq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already depend on rq for builds, and AFAIK rq can do xml -> json too. So perhaps we should use that here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ cat p.xml | rq -i xml --indent " "
{
"root": {
"p": {
"a": "1",
"b": "2",
"c": "3"
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Have fixed this now to use rq and the cached binary too.
-d build/workflows/update-example-index/process.rego \ | ||
--format=raw \ | ||
--stdin-input \ | ||
| jq \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I have replaced with --format=pretty
|
||
name := p[1] | ||
|
||
not count({p | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not count
looks fishy... even if it's the >
being negated. < 2
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that doesn't look good... I have fixed to your version now.
10da4e1
to
3afbf76
Compare
3afbf76
to
09f4a1a
Compare
Signed-off-by: Charlie Egan <[email protected]>
09f4a1a
to
b236cc6
Compare
Think all addressed here now so going to merge for a final test on main. |
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
As pages are added to docs.styra.com/opa/rego-by-example, this json file will be updated meaning more keywords and builtins will be linked in the Regal hover messages.