feat: update

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe · Aug 8, 2023 · 24e1e9a · 24e1e9a
1 parent 1bbf441
commit 24e1e9a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 22 deletions.
diff --git a/src/core/public/saved_objects/saved_objects_client.ts b/src/core/public/saved_objects/saved_objects_client.ts
@@ -266,13 +266,9 @@ export class SavedObjectsClient {
     };
     const currentWorkspaceId = this._getCurrentWorkspace();
     let finalWorkspaces;
-    if (options.workspaces) {
+    if (options.hasOwnProperty('workspaces')) {
       finalWorkspaces = options.workspaces;
     } else if (typeof currentWorkspaceId === 'string') {
-      /**
-       * When the currentWorkspaceId is an empty string instead of undefined
-       * It means user is creating object in public workspace.
-       */
       finalWorkspaces = [currentWorkspaceId];
     }
 
@@ -383,10 +379,13 @@ export class SavedObjectsClient {
 
     const currentWorkspaceId = this._getCurrentWorkspace();
     let finalWorkspaces;
-    if (options.workspaces) {
+    if (options.hasOwnProperty('workspaces')) {
       finalWorkspaces = options.workspaces;
     } else if (typeof currentWorkspaceId === 'string') {
-      finalWorkspaces = currentWorkspaceId ? [PUBLIC_WORKSPACE, currentWorkspaceId] : undefined;
+      finalWorkspaces =
+        currentWorkspaceId === PUBLIC_WORKSPACE
+          ? undefined
+          : [PUBLIC_WORKSPACE, currentWorkspaceId];
     }
 
     const renamedQuery = renameKeys<SavedObjectsFindOptions, any>(renameMap, {

diff --git a/src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts b/src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
@@ -220,19 +220,7 @@ export class WorkspaceSavedObjectsClientWrapper {
             throw generateWorkspacePermissionError();
           }
         } else {
-          const queryDSL = ACL.genereateGetPermittedSavedObjectsQueryDSL(
-            [
-              PermissionMode.LibraryRead,
-              PermissionMode.LibraryWrite,
-              PermissionMode.Management,
-              PermissionMode.Read,
-              PermissionMode.Write,
-            ],
-            principals,
-            options.type
-          );
           options.workspaces = permittedWorkspaceIds;
-          options.queryDSL = queryDSL;
         }
       }
 

diff --git a/src/core/server/workspaces/workspaces_client.ts b/src/core/server/workspaces/workspaces_client.ts
@@ -46,10 +46,13 @@ export class WorkspacesClientWithSavedObject implements IWorkspaceDBImpl {
     requestDetail: IRequestDetail,
     payload: Omit<WorkspaceAttribute, 'id'>
   ): ReturnType<IWorkspaceDBImpl['create']> {
+    const { permissions, ...others } = payload;
     try {
       const result = await this.getSavedObjectClientsFromRequestDetail(requestDetail).create<
-        Omit<WorkspaceAttribute, 'id'>
-      >(WORKSPACE_TYPE, payload);
+        Omit<WorkspaceAttribute, 'id' | 'permissions'>
+      >(WORKSPACE_TYPE, others, {
+        permissions,
+      });
       return {
         success: true,
         result: {

diff --git a/.../saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx b/.../saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
@@ -180,7 +180,7 @@ export class SavedObjectsTable extends Component<SavedObjectsTableProps, SavedOb
   }
 
   private get workspaceIdQuery() {
-    return this.state.workspaceId
+    return this.state.workspaceId !== PUBLIC_WORKSPACE && this.state.workspaceId
       ? Array.from(new Set([PUBLIC_WORKSPACE, this.state.workspaceId]))
       : undefined;
   }