feat: address comments

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe · Apr 2, 2024 · b7a6cb7 · b7a6cb7
1 parent 1b32316
commit b7a6cb7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts b/src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts
@@ -63,9 +63,7 @@ export async function createOrUpgradeSavedConfig(
 
   try {
     // create the new SavedConfig
-    await savedObjectsClient.create('config', attributes, {
-      id: version,
-    });
+    await savedObjectsClient.create('config', attributes, { id: version });
   } catch (error) {
     if (handleWriteErrors) {
       if (SavedObjectsErrorHelpers.isConflictError(error)) {

diff --git a/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.test.ts b/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.test.ts
@@ -50,7 +50,7 @@ describe('WorkspaceIdConsumerWrapper', () => {
       );
     });
 
-    it(`Should use options.workspaces when there is no workspaces inside options`, async () => {
+    it(`Should not use options.workspaces when there is no workspaces inside options`, async () => {
       await wrapperClient.create(
         'dashboard',
         {

diff --git a/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts b/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
@@ -71,6 +71,7 @@ export class WorkspaceIdConsumerWrapper {
       bulkUpdate: wrapperOptions.client.bulkUpdate,
       addToNamespaces: wrapperOptions.client.addToNamespaces,
       deleteFromNamespaces: wrapperOptions.client.deleteFromNamespaces,
+      deleteByWorkspace: wrapperOptions.client.deleteByWorkspace,
     };
   };