compare workspace branches #10

SuZhou-Joe · 2024-02-27T02:34:27Z

Description

Issues Resolved

Screenshot

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…earch-project#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <[email protected]> * change pr number Signed-off-by: Lu Yu <[email protected]> * remove dangling changelog Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>

codecov-commenter · 2024-02-27T04:50:21Z

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 66.97%. Comparing base (790c076) to head (8a98150).
Report is 27 commits behind head on feature/optional-workspaces-params-in-repository.

Files	Patch %	Lines
...rc/core/server/saved_objects/routes/bulk_create.ts	0.00%	2 Missing ⚠️
src/core/server/saved_objects/routes/create.ts	0.00%	2 Missing ⚠️
...ved_objects/service/lib/search_dsl/query_params.ts	66.66%	1 Missing and 1 partial ⚠️
src/core/server/saved_objects/routes/export.ts	0.00%	1 Missing ⚠️
...ore/server/saved_objects/service/lib/repository.ts	80.00%	0 Missing and 1 partial ⚠️
src/core/server/saved_objects/service/lib/utils.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                                 Coverage Diff                                  @@
##           feature/optional-workspaces-params-in-repository      #10      +/-   ##
====================================================================================
- Coverage                                             67.00%   66.97%   -0.04%     
====================================================================================
  Files                                                  3307     3307              
  Lines                                                 63614    63628      +14     
  Branches                                              10163    10170       +7     
====================================================================================
- Hits                                                  42627    42612      -15     
- Misses                                                18518    18524       +6     
- Partials                                               2469     2492      +23

Flag	Coverage Δ
Linux_1	`35.21% <ø> (ø)`
Linux_2	`?`
Linux_3	`43.60% <0.00%> (-0.02%)`	⬇️
Linux_4	`35.18% <0.00%> (-0.02%)`	⬇️
Windows_1	`35.24% <ø> (ø)`
Windows_2	`55.06% <52.63%> (+<0.01%)`	⬆️
Windows_3	`43.62% <0.00%> (-0.02%)`	⬇️
Windows_4	`35.18% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashwin P Chandran <[email protected]>

…passed for the dataSourceId. (opensearch-project#5882) * [MD] Using legacy client cofig instead of globle config Signed-off-by: Xinrui Bai <[email protected]> * [UT] add test cases to test different hostconfig and datasourceId combinations of scenario Signed-off-by: Xinrui Bai <[email protected]> * Update changelog file Signed-off-by: Xinrui Bai <[email protected]> * Resolve comments Signed-off-by: Xinrui Bai <[email protected]> * [UT] update test cases and resolve comments Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update unit test Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]>

…#5970) Signed-off-by: Bandini Bhopi <[email protected]>

…ng numerals (opensearch-project#5956) Signed-off-by: Miki <[email protected]>

…configuration (opensearch-project#5916) * [AuthType Config] Add EnabledAuthType configuration in yml file and pass value to dataSourceManagement root mount Signed-off-by: Xinrui Bai <[email protected]> * [AuthType Config] provide default auth types when types array is empty Signed-off-by: Xinrui Bai <[email protected]> * [AuthRegistry Onboard - DataSourceCreationForm] Integrate auth cofig with AuthRegistray and providing data source options from AuthRegistry Signed-off-by: Xinrui Bai <[email protected]> * [AuthRegistry Onboard] Support default selected auth type in datasource creation page Signed-off-by: Xinrui Bai <[email protected]> * [AuthRegistry Onboard] SDisable auth option selector when auth options no more than 1 Signed-off-by: Xinrui Bai <[email protected]> * [AuthRegistry Onboard] clear credential attribute every time use select NoAuth option. Also update credentialField data type Signed-off-by: Xinrui Bai <[email protected]> * Update yml file to disable config Signed-off-by: Xinrui Bai <[email protected]> * Update change.md file Signed-off-by: Xinrui Bai <[email protected]> * [UT] Fix broken test cases Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add more unit tests Signed-off-by: Xinrui Bai <[email protected]> * [UT] update unit test and handle scenario when no options enabled Signed-off-by: Xinrui Bai <[email protected]> * [UT] update description of unit test case Signed-off-by: Xinrui Bai <[email protected]> * [UT] update unit test cases to resolve comment Signed-off-by: Xinrui Bai <[email protected]> * [UT] Snapshot auth option super selector for unit test. Also upate the default message in datasorurce creation form ---> auth type section Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]>

) Signed-off-by: Miki <[email protected]>

* feat: add ruanyl as a maintainer Signed-off-by: SuZhou-Joe <[email protected]> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

* add BionIT as a maintainer Signed-off-by: Flyingliuhub <[email protected]> * update pr link in the changelog.md Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]>

…th type (opensearch-project#5997) * fix schema for test connection Signed-off-by: Lu Yu <[email protected]> * add changelog Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>

…t#5855) * Add application configuration service Signed-off-by: Tianle Huang <[email protected]> * update API path name Signed-off-by: Tianle Huang <[email protected]> * implement two APIs/interfaces Signed-off-by: Tianle Huang <[email protected]> * expose get function for other plugins to use Signed-off-by: Tianle Huang <[email protected]> * update interfaces Signed-off-by: Tianle Huang <[email protected]> * implement the APIs and interfaces Signed-off-by: Tianle Huang <[email protected]> * add license and jsdoc Signed-off-by: Tianle Huang <[email protected]> * update docs Signed-off-by: Tianle Huang <[email protected]> * add more docs Signed-off-by: Tianle Huang <[email protected]> * update variable name Signed-off-by: Tianle Huang <[email protected]> * remove unnecessary dependency Signed-off-by: Tianle Huang <[email protected]> * format readme Signed-off-by: Tianle Huang <[email protected]> * use osd version Signed-off-by: Tianle Huang <[email protected]> * remove debugging info Signed-off-by: Tianle Huang <[email protected]> * update logging Signed-off-by: Tianle Huang <[email protected]> * remove lint js Signed-off-by: Tianle Huang <[email protected]> * remove logs Signed-off-by: Tianle Huang <[email protected]> * update name style Signed-off-by: Tianle Huang <[email protected]> * update Signed-off-by: Tianle Huang <[email protected]> * update function visibility and error function Signed-off-by: Tianle Huang <[email protected]> * fix unit test failures Signed-off-by: Tianle Huang <[email protected]> * add unit test Signed-off-by: Tianle Huang <[email protected]> * remove lint file Signed-off-by: Tianle Huang <[email protected]> * add more tests Signed-off-by: Tianle Huang <[email protected]> * add unit tests for routes Signed-off-by: Tianle Huang <[email protected]> * add remaining unit tests Signed-off-by: Tianle Huang <[email protected]> * add enabled to this plugin Signed-off-by: Tianle Huang <[email protected]> * update readme to mention experimental Signed-off-by: Tianle Huang <[email protected]> * update change log Signed-off-by: Tianle Huang <[email protected]> * dummy commit to trigger workflow rerun Signed-off-by: Tianle Huang <[email protected]> * remove experimental Signed-off-by: Tianle Huang <[email protected]> * add key to yml file Signed-off-by: Tianle Huang <[email protected]> * remove i18n Signed-off-by: Tianle Huang <[email protected]> * remove lint rc Signed-off-by: Tianle Huang <[email protected]> * update comment style Signed-off-by: Tianle Huang <[email protected]> * add input validation Signed-off-by: Tianle Huang <[email protected]> * update unit tests Signed-off-by: Tianle Huang <[email protected]> * prevent multiple registration Signed-off-by: Tianle Huang <[email protected]> * add return types Signed-off-by: Tianle Huang <[email protected]> * update readme wording Signed-off-by: Tianle Huang <[email protected]> * add unit test to the plugin class about double register Signed-off-by: Tianle Huang <[email protected]> * move related ymls Signed-off-by: Tianle Huang <[email protected]> * move validation to a function Signed-off-by: Tianle Huang <[email protected]> * use trimmed versions Signed-off-by: Tianle Huang <[email protected]> * reword changelog entry Signed-off-by: Tianle Huang <[email protected]> * readability Signed-off-by: Tianle Huang <[email protected]> * add back yml change Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

…s enabled Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

github-actions bot added the first-time-contributor label Feb 27, 2024

ashwin-pc and others added 5 commits February 27, 2024 09:18

skip workflow for non release branches on push (opensearch-project#5964)

53545ac

Signed-off-by: Ashwin P Chandran <[email protected]>

Fixes authentication_methods_registry.mock module (opensearch-project…

a449f70

…#5970) Signed-off-by: Bandini Bhopi <[email protected]>

[osd/std] Add additional recovery from false-positives in handling lo…

a7ab795

…ng numerals (opensearch-project#5956) Signed-off-by: Miki <[email protected]>

SuZhou-Joe force-pushed the feature/workspace-parameters branch from e79522a to 9ebadcd Compare February 28, 2024 02:33

Fix link to documentation for geoHash precision (opensearch-project#5967

03e4897

) Signed-off-by: Miki <[email protected]>

SuZhou-Joe force-pushed the feature/workspace-parameters branch from ed4126a to 720e5ba Compare February 29, 2024 09:02

SuZhou-Joe and others added 19 commits February 29, 2024 10:07

[Admin] Add @ruanyl as a maintainer (opensearch-project#5982)

eeb68ca

* feat: add ruanyl as a maintainer Signed-off-by: SuZhou-Joe <[email protected]> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

[Admin] Add @BionIT as a maintainer (opensearch-project#5988)

c2ac4c8

* add BionIT as a maintainer Signed-off-by: Flyingliuhub <[email protected]> * update pr link in the changelog.md Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]>

refact: move workspace specific logic to savedObjectWrapper

b705ce2

Signed-off-by: SuZhou-Joe <[email protected]>

fix: some error

108f254

Signed-off-by: SuZhou-Joe <[email protected]>

feat: fix test error

d391dd6

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove useless config in test

f4213f3

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add CHANGELOG

51aa1d0

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add more unit test

acfb09c

Signed-off-by: SuZhou-Joe <[email protected]>

fix: unit test

9f2f56d

Signed-off-by: SuZhou-Joe <[email protected]>

feat: revert test in repository.test.js

c7585cc

Signed-off-by: SuZhou-Joe <[email protected]>

feat: revert test in import_saved_objects.test.ts

a476600

Signed-off-by: SuZhou-Joe <[email protected]>

feat: revert test in repository.test.js

3fc01b6

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add type

08508a4

Signed-off-by: SuZhou-Joe <[email protected]>

fix: bootstrap type error

5f932f5

Signed-off-by: SuZhou-Joe <[email protected]>

feat: optimize code and add comment

803ac7d

Signed-off-by: SuZhou-Joe <[email protected]>

fix: unit test error

4d4cb22

Signed-off-by: SuZhou-Joe <[email protected]>

fix: integration test fail

8551809

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe and others added 12 commits March 2, 2024 22:10

feat: add missing code

2e01f65

Signed-off-by: SuZhou-Joe <[email protected]>

feat: optimize code

6ef6e74

Signed-off-by: SuZhou-Joe <[email protected]>

Add permissions field to the mapping only if the permission control i…

3e239b8

…s enabled Signed-off-by: gaobinlong <[email protected]>

Fix test failure

816241a

Signed-off-by: gaobinlong <[email protected]>

feat: modify unit test

516307e

Signed-off-by: SuZhou-Joe <[email protected]>

fix: bulk create error

ad41030

Signed-off-by: SuZhou-Joe <[email protected]>

fix: bulk create error

419b8c4

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add new config in yml file

40fdc96

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add new config in yml file

09f5030

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update yml file

04c1d86

Signed-off-by: SuZhou-Joe <[email protected]>

feat: fix unit test

833517b

Signed-off-by: SuZhou-Joe <[email protected]>

feat: do not skip migration when doing integration test

02c8859

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the feature/workspace-parameters branch from 6752994 to 02c8859 Compare March 2, 2024 14:10

SuZhou-Joe added 4 commits March 3, 2024 22:06

feat: remove useless code

7b368fd

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove useless code

aa49775

Signed-off-by: SuZhou-Joe <[email protected]>

feat: change flag variable

10adb9f

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add test cases

984d51a

Signed-off-by: SuZhou-Joe <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compare workspace branches #10

compare workspace branches #10

SuZhou-Joe commented Feb 27, 2024

codecov-commenter commented Feb 27, 2024 •

edited

Loading

compare workspace branches #10

Are you sure you want to change the base?

compare workspace branches #10

Conversation

SuZhou-Joe commented Feb 27, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter commented Feb 27, 2024 • edited Loading

Codecov Report

codecov-commenter commented Feb 27, 2024 •

edited

Loading