Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/temp merge #12

Draft
wants to merge 196 commits into
base: feature/workspace-parameters
Choose a base branch
from
Draft

Feature/temp merge #12

wants to merge 196 commits into from

Conversation

SuZhou-Joe
Copy link
Owner

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ruanyl and others added 30 commits September 15, 2023 15:49
@ruanyl
setup workspace plugin project skeleton
33bb32c 
Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl
test: add unit tests
f7c76eb 
add license header

Signed-off-by: Yulong Ruan <[email protected]>
@Hailong-am @ruanyl
workspace template init commit
e7d4a62 
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am @ruanyl
refacter workspace template into hooks
dba3c12 
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am @ruanyl
refacter workspace template hooks
010c62c 
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am @ruanyl
update coverImage comments
378f077 
Signed-off-by: Hailong Cui <[email protected]>
@SuZhou-Joe @ruanyl
feature: add public/workspaces service
8f9b956 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: add interfaces for workspaces client
8a31975 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: add interfaces for workspaces client
08d22f8 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: add interfaces for workspaces client
26d3783 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: implement workspaces service
fc4437f 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: changes to client type interface
c96d139 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: changes to client implement
ba26ff1 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: implement more for workspaces service
93882ad 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: implement more for workspaces service
aa0d70a 
Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: implement more for workspaces service
8fb8972 
Signed-off-by: SuZhoue-Joe <[email protected]>
@wanglam @ruanyl
feat: add workspace creator page (#5)
c6c7cf5 
* feat: add workspace creator page

Signed-off-by: Lin Wang <[email protected]>

* feat: integrate with application workspace template

Signed-off-by: Lin Wang <[email protected]>

* feat: add max-width and remove image wrapper if not exists

Signed-off-by: Lin Wang <[email protected]>

* feat: update filter condition to align with collapsible nav

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@SuZhou-Joe @ruanyl
Add validation when load page (#8)
27198dc 
* fix: validation & query

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: modify file name to reduce confusion

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add landing logic to retrive workspace id

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add worklist observable

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add worklist observable

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add worklist observable

Signed-off-by: SuZhoue-Joe <[email protected]>

* fix: type error

Signed-off-by: SuZhoue-Joe <[email protected]>

* fix: type error

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: make client more robust

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: use Subject

Signed-off-by: SuZhoue-Joe <[email protected]>

---------

Signed-off-by: SuZhoue-Joe <[email protected]>
@SuZhou-Joe @ruanyl
feat: use BehaviorObject and optimize code (#14)
7024525 
Signed-off-by: SuZhoue-Joe <[email protected]>
@wanglam @ruanyl
feat: integrate with workspace create API (#13)
5105abc 
* feat: integrate with workspace create API

Signed-off-by: Lin Wang <[email protected]>

* feat: update to i18n text for toast

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@SuZhou-Joe @ruanyl
Add currentWorkspace$ (#15)
cbebb5e 
* feat: add currentWorkspace$

Signed-off-by: SuZhoue-Joe <[email protected]>

* fix: type error

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add emit on currentWorkspace$

Signed-off-by: SuZhoue-Joe <[email protected]>

---------

Signed-off-by: SuZhoue-Joe <[email protected]>
@Hailong-am @ruanyl
register plugin with workspace template (#16)
b560945 
Signed-off-by: Hailong Cui <[email protected]>
@zhichao-aws @SuZhou-Joe @ruanyl
workspace dropdown list (#9)
0ed84c1 
Add workspace dropdown list 

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: suzhou <[email protected]>
Co-authored-by: SuZhoue-Joe <[email protected]>
@raintygao @ruanyl
init workspace menu stage 1 (#12)
2b143cd 
* feat: init workspace menu stage 1

Signed-off-by: tygao <[email protected]>

* fix: remove port diff

Signed-off-by: tygao <[email protected]>

* feat: update menu logic

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
@Hailong-am @ruanyl
Fix template registration import error (opensearch-project#21)
c596448 
* fix import error

Signed-off-by: Hailong Cui <[email protected]>

* fix osd bootstrap failure

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
@wanglam @ruanyl
Add workspace overview page (#19)
309efba 
* feat: add workspace overview page

Signed-off-by: Lin Wang <[email protected]>

* refactor: move paths to common constants

Signed-off-by: Lin Wang <[email protected]>

* feat: add workspace overview item by custom nav in start phase

Signed-off-by: Lin Wang <[email protected]>

* refactor: change to currentWorkspace$ in workspace client

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@wanglam @ruanyl
feat: navigate to workspace create page after button clicked (opensea…
61b29c3 
…rch-project#23)

Signed-off-by: Lin Wang <[email protected]>
@ruanyl
fix failed test snapshots (opensearch-project#22)
0f92bdb 
fix failed test snapshots

temporary fix: fetch functional test from main branch

fixed git error which cannot find ref due to feature branch `workspace`
not exists on repo opensearch-dashboards-functional-test

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
@zhichao-aws @ruanyl
change to currentWorkspace, wrap title using i18n (opensearch-project#20
ec02b38 
)

* change to currentWorkspace, wrap title using i18n

Signed-off-by: zhichao-aws <[email protected]>

* change import

Signed-off-by: zhichao-aws <[email protected]>

* directly return [] if currentWorkspace is null

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
@raintygao @ruanyl
add workspace switch (#17)
6aa12fa 
* feat: update workspace switch

Signed-off-by: tygao <[email protected]>

* fix: fix switch error

Signed-off-by: tygao <[email protected]>

* fix: fix prettier after merge

Signed-off-by: tygao <[email protected]>

* chore: remove extra code after merge

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
yuye-aws and others added 26 commits October 19, 2023 17:44
@yuye-aws
feature: cannot delete last admin user/group in workspace settings (o…
1ac7ec4 
…pensearch-project#235)

* feature: cannot delete last admin user/group in workspace settings

Signed-off-by: yuye-aws <[email protected]>

* refactor code with useMemo

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
@wanglam
Feat disable duplicate user or group permission (opensearch-project#242)
1d679f8 
* feat: throw error when create or update with invalid permission modes

Signed-off-by: Lin Wang <[email protected]>

* feat: show error when duplicate permissions for spefic user or group

Signed-off-by: Lin Wang <[email protected]>

* feat: mark permissions optional

Signed-off-by: Lin Wang <[email protected]>

* feat: change to WorkpsacePermissionItems for workspace client interfaces

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@Hailong-am
Add simple string query flags options to find method (opensearch-proj…
7e2ace0 
…ect#239)

* Add simple string query flags options to find method

Signed-off-by: Hailong Cui <[email protected]>

* fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* Add unit test

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
@yuye-aws @ruanyl
[Backport workspace] Left navigation menu adjustment (opensearch-proj…
f4dfa30 
…ect#192) (opensearch-project#233)

* [Workspace][Feature] Left navigation menu adjustment (opensearch-project#192)

* add util function to filter workspace feature by wildcard

Signed-off-by: Yulong Ruan <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update tests and snapshots

Signed-off-by: yuye-aws <[email protected]>

* small adjustment to left menu

Signed-off-by: yuye-aws <[email protected]>

* resolve git conflict

Signed-off-by: yuye-aws <[email protected]>

* rename nav link service function

Signed-off-by: yuye-aws <[email protected]>

* unit test for workspace plugin.ts

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

* optimize code

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

* resolve conflicts

Signed-off-by: yuye-aws <[email protected]>

* restore snapshot

Signed-off-by: yuye-aws <[email protected]>

* update tests

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
@raintygao
update workspace list page (opensearch-project#238)
d1fe469 
* feat: update workspace list

Signed-off-by: tygao <[email protected]>

* test: remove failed snapshots temporarily

Signed-off-by: tygao <[email protected]>

* add i18n

Signed-off-by: tygao <[email protected]>

* update create workspace url

Signed-off-by: tygao <[email protected]>

* use cleanWorkspaceId

Signed-off-by: tygao <[email protected]>

* update menu link

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
@wanglam
fix: permissions missed after workspace update (opensearch-project#245)
dc240eb 
* fix: permissions missed after workspace update

Signed-off-by: Lin Wang <[email protected]>

* remove not used imports

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@wanglam
Merge main to workspace
b748f8f 
Signed-off-by: Lin Wang <[email protected]>
@wanglam
fix management section register
789f451 
Signed-off-by: Lin Wang <[email protected]>
@ruanyl
Merge pull request opensearch-project#247 from wanglam/merge-main-to-…
fe9a4c1 
…workspace

Merge main to workspace
@SuZhou-Joe
refact: move workspace specific logic to savedObjectWrapper
f6593fb 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: some error
64eab2b 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: fix test error
8f8c7a1 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: remove useless config in test
bbf5091 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add CHANGELOG
280862b 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add more unit test
983fe31 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: unit test
f333f36 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: revert test in repository.test.js
81a5056 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: revert test in import_saved_objects.test.ts
8a43348 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: revert test in repository.test.js
6ddac19 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add type
a226813 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: bootstrap type error
8a98150 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: optimize code and add comment
fbcd4d6 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: unit test error
e194b51 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add workspace into includeHiddenTypes (opensearch-project#249)
0e2c02b 
* feat: add workspace into includeHiddenTypes of client wrapper and permission control client

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: hiddenType side effect

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: integration test fail
bfb18d9 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: merge
d7e2b61 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/workspace-parameters branch 3 times, most recently from 6752994 to 02c8859 Compare March 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
first-time-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SuZhou-Joe @ruanyl @Hailong-am @wanglam @zhichao-aws @raintygao @gaobinlong @yuye-aws