Feature/current workspace in server side #18

SuZhou-Joe · 2024-03-25T09:52:15Z

Description

Issues Resolved

Screenshot

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov-commenter · 2024-03-25T12:01:40Z

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (workspace-pr-integr@efe6254). Click here to learn what that means.

Files	Patch %	Lines
src/core/server/utils/workspace.ts	77.77%	0 Missing and 2 partials ⚠️
...ver/saved_objects/workspace_id_consumer_wrapper.ts	90.47%	0 Missing and 2 partials ⚠️
...ore/server/saved_objects/import/check_conflicts.ts	0.00%	0 Missing and 1 partial ⚠️
...rc/core/server/saved_objects/routes/bulk_create.ts	0.00%	1 Missing ⚠️
src/core/server/saved_objects/routes/create.ts	0.00%	1 Missing ⚠️
src/core/server/saved_objects/routes/export.ts	0.00%	1 Missing ⚠️
src/core/server/saved_objects/routes/find.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##             workspace-pr-integr      #18   +/-   ##
======================================================
  Coverage                       ?   66.41%           
======================================================
  Files                          ?     3321           
  Lines                          ?    64675           
  Branches                       ?    10512           
======================================================
  Hits                           ?    42954           
  Misses                         ?    19133           
  Partials                       ?     2588

Flag	Coverage Δ
Linux_	`66.41% <77.50%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <[email protected]>

…#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: unite feature set Signed-off-by: tygao <[email protected]> * update feature utils Signed-off-by: tygao <[email protected]> * update feature utils Signed-off-by: tygao <[email protected]> * use featureMatchConfig Signed-off-by: tygao <[email protected]> * update Signed-off-by: tygao <[email protected]> * add util test Signed-off-by: tygao <[email protected]> * unite feature set Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

* Add workspace overview page (#19) * feat: add workspace overview page Signed-off-by: Lin Wang <[email protected]> * refactor: move paths to common constants Signed-off-by: Lin Wang <[email protected]> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <[email protected]> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> * restore yml Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Lin Wang <[email protected]>

* [Workspace]Add permission control logic for workspace (opensearch-project#6052) * Add permission control for workspace Signed-off-by: Lin Wang <[email protected]> * Add changelog for permission control in workspace Signed-off-by: Lin Wang <[email protected]> * Fix integration tests and remove no need type Signed-off-by: Lin Wang <[email protected]> * Update permission enabled for workspace CRUD integration tests Signed-off-by: Lin Wang <[email protected]> * Change back to config schema Signed-off-by: Lin Wang <[email protected]> * feat: do not append workspaces field when no workspaces present (#6) * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * fix: authInfo destructure (#7) * fix: authInfo destructure Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * Fix permissions assign in attributes Signed-off-by: Lin Wang <[email protected]> * Remove deleteByWorkspace since not exists Signed-off-by: Lin Wang <[email protected]> * refactor: remove formatWorkspacePermissionModeToStringArray Signed-off-by: Lin Wang <[email protected]> * Remove current not used code Signed-off-by: Lin Wang <[email protected]> * Add missing unit tests for permission control Signed-off-by: Lin Wang <[email protected]> * Update workspaces API test describe Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests failed Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Store permissions when savedObjects.permissions.enabled Signed-off-by: Lin Wang <[email protected]> * Add permission control for deleteByWorkspace Signed-off-by: Lin Wang <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Refactor permissions field in workspace create and update API Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Convert permission settings in client side Signed-off-by: Lin Wang <[email protected]> * Fix workspace list always render Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

…roject#6303) (opensearch-project#315) * feat: add APIs to support plugin state in request (opensearch-project#312) * feat: add APIs to support plugin state in request * feat: add APIs to support plugin state in request --------- * feat: update CHANGELOG * feat: update * feat: use request app to store request workspace id * feat: remove useless if --------- Signed-off-by: SuZhou-Joe <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

…pensearch-project#5815) * add log explorer re-directon modal Signed-off-by: Eric <[email protected]> * adjustments to comments Signed-off-by: Eric <[email protected]> * add one missing i18n Signed-off-by: Eric <[email protected]> * add redirection text to group title Signed-off-by: Eric <[email protected]> * include changes in changelog Signed-off-by: Eric <[email protected]> * remove redundent title addition and unnecessary modal toggle functions Signed-off-by: Eric <[email protected]> * remove one comment Signed-off-by: Eric <[email protected]> * add i18n Signed-off-by: Eric <[email protected]> * add unit tests for modal Signed-off-by: Eric <[email protected]> * test id change Signed-off-by: Eric <[email protected]> * add devDependencies for tests Signed-off-by: Eric <[email protected]> * use open confirm api and move mock file to discover mock folder Signed-off-by: Eric <[email protected]> * remove unused type Signed-off-by: Eric <[email protected]> * remove modal for log explorer redirection Signed-off-by: Eric <[email protected]> * modify changelog Signed-off-by: Eric <[email protected]> * remove modal test Signed-off-by: Eric <[email protected]> * remove one modal related test Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>

Signed-off-by: SuZhou-Joe <[email protected]>

…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>

* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]>

…g to top (opensearch-project#6008) * [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will not work. In this PR, we add a ref to EuiPanel directly. Issue Resolve: opensearch-project#6006 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]>

* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <[email protected]>

…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>

…server-side

Signed-off-by: SuZhou-Joe <[email protected]>

github-actions bot added the first-time-contributor label Mar 25, 2024

feat: remove useless code (opensearch-project#310)

e3ce2e2

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the feature/current-workspace-in-server-side branch 2 times, most recently from c8bda17 to 78286c2 Compare March 27, 2024 06:03

feat: remove useless code (opensearch-project#311)

a2cead4

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the feature/current-workspace-in-server-side branch from 78286c2 to 357efa8 Compare March 28, 2024 02:21

SuZhou-Joe added 17 commits April 1, 2024 09:43

feat: POC implementation

66d6096

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add some comment

d275f61

Signed-off-by: SuZhou-Joe <[email protected]>

feat: revert dependency

65f6be3

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update comment

9c5d2d9

Signed-off-by: SuZhou-Joe <[email protected]>

feat: address one TODO

d5638ff

Signed-off-by: SuZhou-Joe <[email protected]>

feat: address TODO

45589cf

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add unit test

5d990c8

Signed-off-by: SuZhou-Joe <[email protected]>

feat: some special logic on specific operation

08dc9e2

Signed-off-by: SuZhou-Joe <[email protected]>

feat: add integration test

d3cccb8

Signed-off-by: SuZhou-Joe <[email protected]>

feat: declare workspaces as empty array for advanced settings

298c2cb

Signed-off-by: SuZhou-Joe <[email protected]>

feat: unified workspaces parameters when parsing from router

85c522d

Signed-off-by: SuZhou-Joe <[email protected]>

feat: improve code coverage

cdbe9a8

Signed-off-by: SuZhou-Joe <[email protected]>

feat: declare workspaces as null

cb7ebd9

Signed-off-by: SuZhou-Joe <[email protected]>

feat: use unified types

294d2c5

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update comment

42e0e05

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove null

1b32316

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the feature/current-workspace-in-server-side branch from 1690013 to 1b32316 Compare April 1, 2024 09:14

SuZhou-Joe and others added 5 commits April 2, 2024 15:37

feat: address comments

b7a6cb7

Signed-off-by: SuZhou-Joe <[email protected]>

feat: use request app to store request workspace id

dd6cebf

Signed-off-by: SuZhou-Joe <[email protected]>

feat: use app state to store request workspace id

7fd5160

Signed-off-by: SuZhou-Joe <[email protected]>

wanglam and others added 15 commits April 7, 2024 13:02

feat: merge workspace-pr-integr

a5b8c70

Signed-off-by: SuZhou-Joe <[email protected]>

fix: unit test (opensearch-project#318)

ee245d7

Signed-off-by: SuZhou-Joe <[email protected]>

feat: merge

d5ccfad

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove useless code

a8ee4b9

Signed-off-by: SuZhou-Joe <[email protected]>

[Bug][Discover] Allow saved sort from search embeddable to load in Da…

9b9fd57

…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>

[Discover] Fix lazy loading (opensearch-project#6041)

fc1fbe4

* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <[email protected]>

[Discover] options button in canvas to toggle legacy mode (opensearch…

1f2cb35

…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>

Merge branch 'workspace-pr-integr' into feature/current-workspace-in-…

431aa38

…server-side

refact: update types declaration

742ec22

Signed-off-by: SuZhou-Joe <[email protected]>

fix: unit test error

ab0486e

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe closed this Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/current workspace in server side #18

Feature/current workspace in server side #18

SuZhou-Joe commented Mar 25, 2024

codecov-commenter commented Mar 25, 2024 •

edited

Loading

Feature/current workspace in server side #18

Feature/current workspace in server side #18

Conversation

SuZhou-Joe commented Mar 25, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter commented Mar 25, 2024 • edited Loading

Codecov Report

codecov-commenter commented Mar 25, 2024 •

edited

Loading