forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store workspace into path #6
Open
SuZhou-Joe
wants to merge
18
commits into
main
Choose a base branch
from
feature/stateful_url_path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
force-pushed
the
feature/stateful_url_path
branch
from
October 7, 2023 07:54
6b7cfb1
to
a52f4dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 67.00% 67.00% -0.01%
==========================================
Files 3307 3318 +11
Lines 63614 64038 +424
Branches 10163 10261 +98
==========================================
+ Hits 42627 42910 +283
- Misses 18518 18614 +96
- Partials 2469 2514 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat: add ruanyl as a maintainer Signed-off-by: SuZhou-Joe <[email protected]> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
* add BionIT as a maintainer Signed-off-by: Flyingliuhub <[email protected]> * update pr link in the changelog.md Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]>
…th type (opensearch-project#5997) * fix schema for test connection Signed-off-by: Lu Yu <[email protected]> * add changelog Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
…t#5855) * Add application configuration service Signed-off-by: Tianle Huang <[email protected]> * update API path name Signed-off-by: Tianle Huang <[email protected]> * implement two APIs/interfaces Signed-off-by: Tianle Huang <[email protected]> * expose get function for other plugins to use Signed-off-by: Tianle Huang <[email protected]> * update interfaces Signed-off-by: Tianle Huang <[email protected]> * implement the APIs and interfaces Signed-off-by: Tianle Huang <[email protected]> * add license and jsdoc Signed-off-by: Tianle Huang <[email protected]> * update docs Signed-off-by: Tianle Huang <[email protected]> * add more docs Signed-off-by: Tianle Huang <[email protected]> * update variable name Signed-off-by: Tianle Huang <[email protected]> * remove unnecessary dependency Signed-off-by: Tianle Huang <[email protected]> * format readme Signed-off-by: Tianle Huang <[email protected]> * use osd version Signed-off-by: Tianle Huang <[email protected]> * remove debugging info Signed-off-by: Tianle Huang <[email protected]> * update logging Signed-off-by: Tianle Huang <[email protected]> * remove lint js Signed-off-by: Tianle Huang <[email protected]> * remove logs Signed-off-by: Tianle Huang <[email protected]> * update name style Signed-off-by: Tianle Huang <[email protected]> * update Signed-off-by: Tianle Huang <[email protected]> * update function visibility and error function Signed-off-by: Tianle Huang <[email protected]> * fix unit test failures Signed-off-by: Tianle Huang <[email protected]> * add unit test Signed-off-by: Tianle Huang <[email protected]> * remove lint file Signed-off-by: Tianle Huang <[email protected]> * add more tests Signed-off-by: Tianle Huang <[email protected]> * add unit tests for routes Signed-off-by: Tianle Huang <[email protected]> * add remaining unit tests Signed-off-by: Tianle Huang <[email protected]> * add enabled to this plugin Signed-off-by: Tianle Huang <[email protected]> * update readme to mention experimental Signed-off-by: Tianle Huang <[email protected]> * update change log Signed-off-by: Tianle Huang <[email protected]> * dummy commit to trigger workflow rerun Signed-off-by: Tianle Huang <[email protected]> * remove experimental Signed-off-by: Tianle Huang <[email protected]> * add key to yml file Signed-off-by: Tianle Huang <[email protected]> * remove i18n Signed-off-by: Tianle Huang <[email protected]> * remove lint rc Signed-off-by: Tianle Huang <[email protected]> * update comment style Signed-off-by: Tianle Huang <[email protected]> * add input validation Signed-off-by: Tianle Huang <[email protected]> * update unit tests Signed-off-by: Tianle Huang <[email protected]> * prevent multiple registration Signed-off-by: Tianle Huang <[email protected]> * add return types Signed-off-by: Tianle Huang <[email protected]> * update readme wording Signed-off-by: Tianle Huang <[email protected]> * add unit test to the plugin class about double register Signed-off-by: Tianle Huang <[email protected]> * move related ymls Signed-off-by: Tianle Huang <[email protected]> * move validation to a function Signed-off-by: Tianle Huang <[email protected]> * use trimmed versions Signed-off-by: Tianle Huang <[email protected]> * reword changelog entry Signed-off-by: Tianle Huang <[email protected]> * readability Signed-off-by: Tianle Huang <[email protected]> * add back yml change Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]>
…ct#5949) * refact: move workspace specific logic to savedObjectWrapper Signed-off-by: SuZhou-Joe <[email protected]> * fix: some error Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix test error Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless config in test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: add more unit test Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert test in import_saved_objects.test.ts Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <[email protected]> * feat: add type Signed-off-by: SuZhou-Joe <[email protected]> * fix: bootstrap type error Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code and add comment Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> * fix: integration test fail Signed-off-by: SuZhou-Joe <[email protected]> * feat: add missing code Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * feat: modify unit test Signed-off-by: SuZhou-Joe <[email protected]> * fix: bulk create error Signed-off-by: SuZhou-Joe <[email protected]> * fix: bulk create error Signed-off-by: SuZhou-Joe <[email protected]> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <[email protected]> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <[email protected]> * feat: update yml file Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: do not skip migration when doing integration test Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: change flag variable Signed-off-by: SuZhou-Joe <[email protected]> * feat: add test cases Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…g to top (opensearch-project#6008) * [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will not work. In this PR, we add a ref to EuiPanel directly. Issue Resolve: opensearch-project#6006 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
…ct#6012) * feat: temp save Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add some comment Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
…opensearch-project#6002) * [TokenExchange] Render credential form registered from AuthMethod Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add unittest to test registered credential form get rendered in create datasource page Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update test case descriptions Signed-off-by: Xinrui Bai <[email protected]> * [Token Exchange] improve code format in create datasource page Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add unit test for edit datasource page Signed-off-by: Xinrui Bai <[email protected]> * Update changelog file Signed-off-by: Xinrui Bai <[email protected]> * update yml config file to original status Signed-off-by: Xinrui Bai <[email protected]> * Resolving comments Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add more unit test to cover existing auth type and plugin registered Auth type scenario Signed-off-by: Xinrui Bai <[email protected]> * Resolving comments, update pmport path Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]>
…oject#6019) (cherry picked from commit 1da1320) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Workspace] Add ACL related functions for workspace (opensearch-project#146) * [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> * Modify changelog Signed-off-by: gaobinlong <[email protected]> * Add more unit test cases Signed-off-by: gaobinlong <[email protected]> * Modify test case Signed-off-by: gaobinlong <[email protected]> * Some minor change Signed-off-by: gaobinlong <[email protected]> * Add more test cases Signed-off-by: gaobinlong <[email protected]> * Optimize some code and the comments of the functions Signed-off-by: gaobinlong <[email protected]> * Add more comments for some basic functions Signed-off-by: gaobinlong <[email protected]> * Export more interfaces Signed-off-by: gaobinlong <[email protected]> * consume permissions in repository Signed-off-by: SuZhou-Joe <[email protected]> * feat: consume permissions in serializer Signed-off-by: SuZhou-Joe <[email protected]> * Add unit tests for consuming permissions in repository Signed-off-by: gaobinlong <[email protected]> * Remove double exclamation Signed-off-by: gaobinlong <[email protected]> * Rename some variables Signed-off-by: gaobinlong <[email protected]> * Remove duplicated semicolon Signed-off-by: gaobinlong <[email protected]> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * Add feature flag config to the yml file Signed-off-by: gaobinlong <[email protected]> * Make the comment of feature flag more clear Signed-off-by: gaobinlong <[email protected]> * Make comment more clear Signed-off-by: gaobinlong <[email protected]> * Remove management permission type Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
…tup (opensearch-project#6030) * expose picker using function in plugin setup Signed-off-by: Lu Yu <[email protected]> * add changelog and test Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <[email protected]>
…eld (opensearch-project#6025) This PR is to add a migration function with version 2.4.0 for datasource to add a migrationVersion field. For more information, please refer to the RFC: opensearch-project#6022 Issues Resolved opensearch-project#6022 Signed-off-by: Yibo Wang <[email protected]>
…pensearch-project#6042) * change component name Signed-off-by: Lu Yu <[email protected]> * add change log Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
* Correct CHANGELOG Signed-off-by: Bandini Bhopi <[email protected]> * Remove empty line Signed-off-by: Bandini Bhopi <[email protected]> * Corrected link for 6025 Signed-off-by: Bandini Bhopi <[email protected]> --------- Signed-off-by: Bandini Bhopi <[email protected]>
SuZhou-Joe
force-pushed
the
feature/stateful_url_path
branch
from
March 7, 2024 03:02
b803de8
to
7130b3c
Compare
Signed-off-by: SuZhoue-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhoue-Joe <[email protected]> feat: remove useless change Signed-off-by: SuZhoue-Joe <[email protected]> feat: optimize url listener Signed-off-by: SuZhoue-Joe <[email protected]> feat: make formatUrlWithWorkspaceId extensible Signed-off-by: SuZhoue-Joe <[email protected]> feat: modify the async format to be sync function Signed-off-by: SuZhoue-Joe <[email protected]> feat: use path to maintain workspace info Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]> feat: format Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/stateful_url_path
branch
from
March 7, 2024 03:05
7130b3c
to
86ac4a8
Compare
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 7, 2024
* feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Apr 3, 2024
…ject#6052) * Add permission control for workspace Signed-off-by: Lin Wang <[email protected]> * Add changelog for permission control in workspace Signed-off-by: Lin Wang <[email protected]> * Fix integration tests and remove no need type Signed-off-by: Lin Wang <[email protected]> * Update permission enabled for workspace CRUD integration tests Signed-off-by: Lin Wang <[email protected]> * Change back to config schema Signed-off-by: Lin Wang <[email protected]> * feat: do not append workspaces field when no workspaces present (#6) * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * fix: authInfo destructure (#7) * fix: authInfo destructure Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * Fix permissions assign in attributes Signed-off-by: Lin Wang <[email protected]> * Remove deleteByWorkspace since not exists Signed-off-by: Lin Wang <[email protected]> * refactor: remove formatWorkspacePermissionModeToStringArray Signed-off-by: Lin Wang <[email protected]> * Remove current not used code Signed-off-by: Lin Wang <[email protected]> * Add missing unit tests for permission control Signed-off-by: Lin Wang <[email protected]> * Update workspaces API test describe Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests failed Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Store permissions when savedObjects.permissions.enabled Signed-off-by: Lin Wang <[email protected]> * Add permission control for deleteByWorkspace Signed-off-by: Lin Wang <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Refactor permissions field in workspace create and update API Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Apr 7, 2024
* [Workspace]Add permission control logic for workspace (opensearch-project#6052) * Add permission control for workspace Signed-off-by: Lin Wang <[email protected]> * Add changelog for permission control in workspace Signed-off-by: Lin Wang <[email protected]> * Fix integration tests and remove no need type Signed-off-by: Lin Wang <[email protected]> * Update permission enabled for workspace CRUD integration tests Signed-off-by: Lin Wang <[email protected]> * Change back to config schema Signed-off-by: Lin Wang <[email protected]> * feat: do not append workspaces field when no workspaces present (#6) * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * fix: authInfo destructure (#7) * fix: authInfo destructure Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * Fix permissions assign in attributes Signed-off-by: Lin Wang <[email protected]> * Remove deleteByWorkspace since not exists Signed-off-by: Lin Wang <[email protected]> * refactor: remove formatWorkspacePermissionModeToStringArray Signed-off-by: Lin Wang <[email protected]> * Remove current not used code Signed-off-by: Lin Wang <[email protected]> * Add missing unit tests for permission control Signed-off-by: Lin Wang <[email protected]> * Update workspaces API test describe Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests failed Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Store permissions when savedObjects.permissions.enabled Signed-off-by: Lin Wang <[email protected]> * Add permission control for deleteByWorkspace Signed-off-by: Lin Wang <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <[email protected]> * Refactor permissions field in workspace create and update API Signed-off-by: Lin Wang <[email protected]> * Fix workspace CRUD API integration tests Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Convert permission settings in client side Signed-off-by: Lin Wang <[email protected]> * Fix workspace list always render Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Jul 1, 2024
…ject#6052) (opensearch-project#6531) * Add permission control for workspace * Add changelog for permission control in workspace * Fix integration tests and remove no need type * Update permission enabled for workspace CRUD integration tests * Change back to config schema * feat: do not append workspaces field when no workspaces present (#6) * feat: do not append workspaces field when no workspaces present * feat: do not append workspaces field when no workspaces present --------- * fix: authInfo destructure (#7) * fix: authInfo destructure * fix: unit test error --------- * Fix permissions assign in attributes * Remove deleteByWorkspace since not exists * refactor: remove formatWorkspacePermissionModeToStringArray * Remove current not used code * Add missing unit tests for permission control * Update workspaces API test describe * Fix workspace CRUD API integration tests failed * Address PR comments * Store permissions when savedObjects.permissions.enabled * Add permission control for deleteByWorkspace * Update src/plugins/workspace/server/permission_control/client.ts * Update src/plugins/workspace/server/permission_control/client.ts * Refactor permissions field in workspace create and update API * Fix workspace CRUD API integration tests --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: ZilongX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration