forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refact: move workspace specific logic to savedObjectWrapper #8
Open
SuZhou-Joe
wants to merge
47
commits into
feature/setup-workspace-server-api-main
Choose a base branch
from
feature/optional-workspaces-params-in-repository-wrapper
base: feature/setup-workspace-server-api-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refact: move workspace specific logic to savedObjectWrapper #8
SuZhou-Joe
wants to merge
47
commits into
feature/setup-workspace-server-api-main
from
feature/optional-workspaces-params-in-repository-wrapper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
…oject#189) * feat: optimize logic when checkConflict and bulkCreate Signed-off-by: SuZhou-Joe <[email protected]> * feat: add options.workspace check Signed-off-by: SuZhou-Joe <[email protected]> * feat: throw error when workspace check error in repository create Signed-off-by: SuZhou-Joe <[email protected]> * feat: modify judgement Signed-off-by: SuZhou-Joe <[email protected]> * feat: always get objects from DB when create-with-override Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
…tory Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
…tory Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
changed the base branch from
main
to
feature/optional-workspaces-params-in-repository
October 18, 2023 08:25
SuZhou-Joe
changed the base branch from
feature/optional-workspaces-params-in-repository
to
feature/setup-workspace-server-api-main
October 18, 2023 08:26
Closed
13 tasks
Signed-off-by: SuZhou-Joe <[email protected]>
…kspace Signed-off-by: Zhou Su <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/optional-workspaces-params-in-repository-wrapper
branch
from
October 18, 2023 08:48
292931a
to
2a8635e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/setup-workspace-server-api-main #8 +/- ##
===========================================================================
- Coverage 66.79% 66.74% -0.05%
===========================================================================
Files 3288 3288
Lines 63132 63169 +37
Branches 10053 10071 +18
===========================================================================
- Hits 42169 42164 -5
- Misses 18489 18602 +113
+ Partials 2474 2403 -71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Jun 8, 2024
…t#6105) * Import sample data to workspace Signed-off-by: Lin Wang <[email protected]> * Enable workspace ui plugin Signed-off-by: Lin Wang <[email protected]> * Add changelog for import sample data to current workspace Signed-off-by: Lin Wang <[email protected]> * feat: register sample data as standalone app (#8) * feat: register sample data as standalone app Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: use props to pass homeLink Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * Retrieve workspace id from request Signed-off-by: Lin Wang <[email protected]> * Remove workspace id in query Signed-off-by: Lin Wang <[email protected]> * Move changelog to fragments Signed-off-by: Lin Wang <[email protected]> * Fix sample data list unit tests Signed-off-by: Lin Wang <[email protected]> * Remove no need workspaces deps Signed-off-by: Lin Wang <[email protected]> * Remove manual created changelogs Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR opensearch-project#6105 created/updated * Enable sample data in workspace overview page (#9) * enable sample data in workspace overview page Signed-off-by: Hailong Cui <[email protected]> * add comments for empty id Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> * Add unit tests for getFinalSavedObjects in data sets util file Signed-off-by: Lin Wang <[email protected]> * Add unit tests for renderImportSampleDataApp destroy Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Remove history listen in renderImportSampleDataApp Signed-off-by: Lin Wang <[email protected]> * Remove Route for workspace import sample data entry point Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Jul 1, 2024
…t#6105) (opensearch-project#6826) * Import sample data to workspace * Enable workspace ui plugin * Add changelog for import sample data to current workspace * feat: register sample data as standalone app (#8) * feat: register sample data as standalone app * feat: optimize code * feat: add comment * feat: use props to pass homeLink * feat: add unit test --------- * Retrieve workspace id from request * Remove workspace id in query * Move changelog to fragments * Fix sample data list unit tests * Remove no need workspaces deps * Remove manual created changelogs * Changeset file for PR opensearch-project#6105 created/updated * Enable sample data in workspace overview page (#9) * enable sample data in workspace overview page * add comments for empty id --------- * Add unit tests for getFinalSavedObjects in data sets util file * Add unit tests for renderImportSampleDataApp destroy * Address PR comments * Remove history listen in renderImportSampleDataApp * Remove Route for workspace import sample data entry point --------- (cherry picked from commit 3e9a159) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration