Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just starting out with Suave (and .NET, F#, monadic composition, etc.) and some instructions felt out of date. No hard feelings if you decide to reject this PR as many changes are obviously opinionated, but it helped me learn a lot by going through the introduction with a fine-toothed comb..:)
What is not clear to me is the part where F#'s
Async.DefaultCancellationToken
is mentioned, but the cancellable example usesSystem.Threading.CancellationTokenSource
.As far as I can tell, the re-written example below is correct (at least, it runs the same way), but don't know for sure so I didn't include it in this PR (yet):
or by re-using
Web.defaultConfig.cancellationToken
(as it is literallyAsync.DefaultCancellationToken
):(I was also trying to figure out why the
CancellationToken
is also needed for the config, but I haven't read the docs all the way through yet, so that will probably be cleared up later. Anyway, thanks for considering!)