Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DET-422: Add support for CSE Rule custom window sizes. #623

Merged

Conversation

pwardecki-sumo
Copy link
Contributor

@pwardecki-sumo pwardecki-sumo commented Feb 21, 2024

Adds support for CSE Rule Custom Window Sizes.

For each of the Rule Types (Threshold, Chain, Aggregation):

  • window_size_millis was added as a new resource field
  • structure and read/create/update functions were updated accordingly
  • because of conditional nature of the new field test scenarios were extended to:
    • createAndUpdate (the old one)
    • createAndUpdateWithCustomWindowSize
    • createAndUpdateToCustomWindowSize

Screen from apply:

Screenshot 2024-03-01 at 12 19 48

@pwardecki-sumo pwardecki-sumo force-pushed the pwardecki/DET-422-cse-rule-custom-window-sizes branch from 8a5c49c to 306024a Compare February 21, 2024 15:49
@alex-reichle alex-reichle self-assigned this Mar 5, 2024
@pwardecki-sumo pwardecki-sumo marked this pull request as ready for review March 6, 2024 19:47
@pwardecki-sumo pwardecki-sumo force-pushed the pwardecki/DET-422-cse-rule-custom-window-sizes branch from 0e7ae26 to 6e50a9f Compare March 7, 2024 15:06
@pwardecki-sumo pwardecki-sumo merged commit 6064499 into master Mar 8, 2024
3 checks passed
@pwardecki-sumo pwardecki-sumo deleted the pwardecki/DET-422-cse-rule-custom-window-sizes branch March 8, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants