Skip to content

Commit

Permalink
Updated code as per PRod changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Pratikshakhandagale committed Aug 16, 2024
2 parents 28dcc27 + 8a92e41 commit f7c8e35
Show file tree
Hide file tree
Showing 12 changed files with 5,190 additions and 1,961 deletions.
18 changes: 17 additions & 1 deletion angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,26 @@
"node_modules/plyr/dist/plyr.js"
],
"serviceWorker": true,
"ngswConfigPath": "ngsw-config.json"
"ngswConfigPath": "ngsw-config.json",
"optimization": {
"scripts": true,
"styles": {
"minify": true,
"inlineCritical": true
},
"fonts": true
}
},
"configurations": {
"production": {
"optimization": {
"scripts": true,
"styles": {
"minify": true,
"inlineCritical": true
},
"fonts": true
},
"budgets": [
{
"type": "initial",
Expand Down
2 changes: 0 additions & 2 deletions hooks/copyGradleProperties.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const appName = properties['app_name'];
const appid = properties['app_id'];
const verCode = properties['app_version_code'];

console.log("****** gradle properties ", properties);
let appId = `applicationId "${appid}"`;
let appendStr = '\t\tapplicationId app_id \n' +
'\t\tresValue("string", "app_name", "${app_name}") \n' +
Expand Down Expand Up @@ -103,7 +102,6 @@ fs.readFile("android/variables.gradle", 'utf-8', (err, data) => {
return;
}
if(data.match("minSdkVersion = 22")) {
console.log("exist ");
let updatedData = data.replace('minSdkVersion = 22', 'minSdkVersion = 23')
fs.writeFile("android/variables.gradle", updatedData, (err) => {
if (err) {
Expand Down
23 changes: 0 additions & 23 deletions hooks/updateManifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,31 +72,8 @@ fs.readFile("android/app/src/main/res/values/styles.xml", 'utf-8', (err, data) =
}
})

// update strings.xml
// fs.readFile("android/app/src/main/res/values/strings.xml", 'utf-8', (err, data) => {
// if(err) {
// console.log(err)
// }
fs.copyFile("configuration/strings.xml", "android/app/src/main/res/values/strings.xml", (err) => {
if(err) {
console.log(err)
}
})
// })

// fs.readFile(proguardPath, 'utf8', (err, data) => {
// if (err) {
// console.error(err);
// return;
// }
// console.log('update proguard ');
// if (data.match("# Please add ")) {

// } else {
// fs.appendFileSync(proguardPath, proguardTxt, (err) => {
// if (err) {
// console.error("********* err", err);
// }
// });
// }
// });
Loading

0 comments on commit f7c8e35

Please sign in to comment.