Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #KN-231 chore: Added the default value for aws and gcloud. #1780

Open
wants to merge 1 commit into
base: release-4.10.1
Choose a base branch
from

Conversation

AmiableAnil
Copy link
Contributor

No description provided.

@@ -581,11 +609,24 @@ content-auto-creator:
learning_service.basePath = "{{ kp_learning_service_base_url }}"
}

#Cloud storage config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate entry. This is already defined on top line 552

aws_storage_container= "{{ aws_storage_container_name }}"

#Google cloud config
gcloud_client_key: "{{ sunbird_gcloud_client_key }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same keys are duplicated multiple times. Check all CSP configuration properties once.

Copy link
Contributor

@vinukumar-vs vinukumar-vs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this way,

Create a separate CSP config file and import for which ever jobs we need
include file("/data/flink/conf/base-config.conf")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants