This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening,
I have been a beta tester of SimpleElastix for a workshop organized by Emanoel Sabidussi with the help Stefan Klein. I found the Compiling On Linux documentation a bit tricky about virtual environment. Indeed, if you follow the documentation blindely copy pasting commands as the following "sudo python Packaging/setup.py install" will install SimpleElastix in your default python2 default environment even if your virtual environment is loaded. That's why I proposed a fix on the documentation with two options one with virtual environment and one without. A more global remark I think that it 's better practice to make a warning to explain that sudo rights are required rather than adding "sudo" at the beginning of each command.
Furthermore, my fix is clearly not perfect, it is the first time that I fork a repo and contribute to library so I might have done something wrong. But I hope that what I did can help in a way.
Best
Robin