Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch file listing API, add route to delete all pins #73

Merged
merged 10 commits into from
Feb 7, 2023

Conversation

govi218
Copy link
Contributor

@govi218 govi218 commented Feb 7, 2023

Changes

Test

  • Update test cases for listing all pins
  • Add test for deleting all pins

@govi218 govi218 requested a review from Kaihuang724 February 7, 2023 02:10
@govi218 govi218 self-assigned this Feb 7, 2023
@govi218 govi218 marked this pull request as draft February 7, 2023 02:10
@govi218 govi218 force-pushed the govi218/patch-file-api branch from 92965bc to 2414277 Compare February 7, 2023 07:30
@govi218
Copy link
Contributor Author

govi218 commented Feb 7, 2023

@Kaihuang724 Note: we lose file attributes for file creator and createdAt; I'm in touch with IPFS devs on slack to see if there's a way to get this info. I'll open an issue to track this.

@govi218
Copy link
Contributor Author

govi218 commented Feb 7, 2023

See #74

@govi218 govi218 marked this pull request as ready for review February 7, 2023 07:48
Copy link
Contributor

@Kaihuang724 Kaihuang724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will adjust the UI to reflect the changes in file metadata

@Kaihuang724 Kaihuang724 merged commit bb5a466 into main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants