-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for AI-Toolbox with required dependencies #69
base: master
Are you sure you want to change the base?
Add Dockerfile for AI-Toolbox with required dependencies #69
Conversation
…rror in MARMaxPolicy.cpp for ranges_ array
Cool, thanks! Could the file be modified as to actually compile the entire project (seems this actually skips a couple of things)? Do you know also if it might be possible to test the file using GitHub Actions? If so, it'd be cool to add an additional test to the actions file together with this. |
Error in MARMaxPolicy.cpp
ctest not passing, hence disabling it for now
Thanks again @Svalorzen for building this toolbox. With the lastest commit, the docker image builds the full package and I have also added a test in the GitHub workflows to test the docker-image build. When I was using the package, I noticed that Python modules for some POMDP solvers, such as SARSOP, Fast Informed Bound, are missing (see line 7239-7265 in |
Ah, it's possible some things are missing in the Python bindings. I may have forgot to add them; the bindings are fairly simple to add at least. At the moment I'm fairly busy but I'll make a note to add them ASAP, as well as reviewing and merging your PR. Hopefully next week I'll have a bit of time for this :) Thanks a lot for the effort! |
CMakeLists.txt
Outdated
set(CMAKE_CXX_STANDARD 20) | ||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
set(CMAKE_CXX_EXTENSIONS OFF) | ||
# set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++2a") | ||
set(CMAKE_CXX_COMPILER g++-10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line absolutely required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it can be removed.
I was unable to install it on my Mac due to the dependencies and complier conflicts, so I created a simple Docker image to install this toolbox. I hope this helps others save time :)
output of cmake