Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spleeter support #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gulnazaki
Copy link

Spleeter is a source separation library by Deezer, with amazing results. I added it as an option because after hearing MaD Twinnet's output I wasn't that satisfied. But, even though vocals now are much more clear the results have not improved, at least for the songs I tried it to.

To play around add --spleeter as an argument to playback.py

@pep8speaks
Copy link

Hello @tom-melistas! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:80: E501 line too long (121 > 79 characters)
Line 48:80: E501 line too long (171 > 79 characters)
Line 51:80: E501 line too long (123 > 79 characters)
Line 125:80: E501 line too long (92 > 79 characters)

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #34 into master will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   76.36%   75.95%   -0.41%     
==========================================
  Files          22       22              
  Lines        1117     1123       +6     
==========================================
  Hits          853      853              
- Misses        264      270       +6     
Impacted Files Coverage Δ
autosynch/playback.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91494c...a894bbd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants