Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msg history #168

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

12944qwerty
Copy link
Contributor

Unflips the messages view. This allows for clicking messages to work properly (namely mentions when I get that released)

However, I did fix the scrolling. Clicking on a reply scrolls to that message and when you switch to a channel, it scrolls to the unread bar or to the bottommost message.

@cryptoAlgorithm
Copy link
Member

One problem here is that it looks like it would scroll to the last message only upon loading, which is not the current (desired) behaviour. Flipping the List has the advantage of keeping the view constantly anchored on the bottom, while elements are added and removed. This allows for a flawless inverted scroll experience expected of a chat app, which was the primary reason for implementing the history list as such.
It is unfortunately difficult to offer the same experience by manually scrolling the list, and I would not like to compromise the existing experience.

@12944qwerty
Copy link
Contributor Author

That should be fixed now. Rotating it by 180 twice gets you to start at bottom immediately without scrolling AND it doesn't sacrifice mouse behaviors. However, it did move the scrollbar to the left which I moved back by adding a geometry reader to get the width of the scrollbar to move it back.

In addition to that, I've also combined the day and unread dividers in those cases.

12944qwerty and others added 2 commits August 3, 2023 22:44
commit e6f8bde
Author: vinkwok <[email protected]>
Date:   Sat Jul 1 13:44:23 2023 +0800

    fix(onboarding): move attributed title declaration out of view body

commit 952ddb9
Author: vinkwok <[email protected]>
Date:   Fri Jun 30 12:16:00 2023 +0800

    fix: remove list dividers added in Xcode 15

commit 0684932
Author: vinkwok <[email protected]>
Date:   Fri Jun 30 12:15:24 2023 +0800

    feat(permissions): channel visibility based on permissions
@cryptoAlgorithm cryptoAlgorithm changed the base branch from main to feat-permissions September 11, 2023 11:12
@12944qwerty 12944qwerty changed the base branch from feat-permissions to main September 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants