Add ability to pick protractor framework to allow cucumber as an e2e … #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is quite a large PR for a new feature so I would love as much feedback as possible to improve it. |
| @@ -19,7 +19,8 @@ module.exports = function (GulpAngularGenerator) { | |||
| this.props.foundationComponents.key, | |||
| this.props.cssPreprocessor.key, | |||
| this.props.jsPreprocessor.key, | |||
| this.props.htmlPreprocessor.key | |||
| this.props.htmlPreprocessor.key, | |||
| this.props.protractorFramework.key | |||
There was a problem hiding this comment.
By adding a new item to the prompt, this causes an error (since this.props.protractorFramework is undefined) when the user loads an existing .yo.rc.
How have you historically managed changes like this?
nabil-boag
force-pushed
the
feat
branch
2 times, most recently
from
1bc4e6b
to
02b17d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…framework.