Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lodash.assign in favour of full fat lodash #835

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use lodash.assign in favour of full fat lodash #835

wants to merge 2 commits into from

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Oct 8, 2015

No description provided.

@zckrs
Copy link
Collaborator

zckrs commented Oct 8, 2015

good initiative but I remember we use others method like foreach, flatten, findwhere, clonedeep, ... etc

@tlvince
Copy link
Contributor Author

tlvince commented Oct 8, 2015

Ah okay, I didn't spot any other usage of lodash in the templates themselves, but I only considered a subset of generator options.

@tlvince tlvince closed this Oct 8, 2015
@zckrs
Copy link
Collaborator

zckrs commented Oct 8, 2015

Sorry my error. I didn't see you modify the sample app.

Can you update NPM shrinkwrap by command $ npm run update-shinrkwrap ?

@zckrs zckrs reopened this Oct 8, 2015
@tlvince
Copy link
Contributor Author

tlvince commented Oct 11, 2015

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlvince @zckrs