R4R: EdDSA with Schnorr support using the secp256k1 curve (Taproot support) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 21, 2021 13:19
…proot. Work in Progress.
… an odd Y coordinate, add aG to it so as to ensure R with even Y coordinate. Even though BIP 340 states that only R.X is used, the R recalculation in btcd/btcec/v2 's Signature.schnorrVerify checks if R = s*G - e*P. Without adding aG to R, it could have an odd Y coordinate and fail verification. This commit also fixed a previous serialization problem with s.
…ng algorithm externally.
gcsfred2
changed the title
…arameter to functions. Updating the protobuf import package.
… No functional change to protocol.
creamwhip
force-pushed
the
feature/taproot_eddsa_S256_ii
branch
2 times, most recently
from
2615fe9
to
ff5c275
Compare
creamwhip
force-pushed
the
feature/taproot_eddsa_S256_ii
branch
from
ff5c275
to
7fbb47a
Compare
creamwhip
force-pushed
the
feature/taproot_eddsa_S256_ii
branch
from
7d6bae8
to
68d2ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EdDSA with Schnorr support using the secp256k1 curve.