Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fail session launch when gitlab couldn't be reached #3727

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: don't fail session launch when gitlab couldn't be reached #3727

wants to merge 2 commits into from

Conversation

Panaetius
Copy link
Member

also merges back master, which was forgotten on that last release it seems.

github-actions bot and others added 2 commits April 9, 2024 08:34
@github-actions
chore: release v2.9.3 (#3724)
0012737 
* fix: make doctor fix for workflow ids also update oid and derived_from (#3723)

* fix(cli): fix the doctor fix for plan ids to reassign oid's

* allow overriding renku lock path

* also fix derived from

* chore: release v2.9.3
@Panaetius
fix: don't fail session launch when gitlab couldn't be reached
128d383
@Panaetius Panaetius requested a review from a team as a code owner May 13, 2024 07:05
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9058668052

Details

  • 15 of 29 (51.72%) changed or added relevant lines in 3 files are covered.
  • 2594 unchanged lines in 125 files lost coverage.
  • Overall coverage decreased (-8.4%) to 77.713%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/config.py 6 8 75.0%
renku/core/session/renkulab.py 3 8 37.5%
renku/command/checks/workflow.py 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
renku/command/format/tabulate.py 1 87.1%
renku/core/util/datetime8601.py 1 77.78%
renku/ui/cli/service.py 1 72.49%
renku/infrastructure/gateway/plan_gateway.py 1 95.0%
renku/domain_model/provenance/agent.py 1 81.72%
renku/infrastructure/persistent.py 1 91.67%
renku/infrastructure/database.py 1 93.15%
renku/domain_model/project_context.py 1 96.45%
renku/core/util/tabulate.py 1 96.3%
renku/core/project.py 1 94.74%
Totals Coverage Status
Change from base Build 8601535111: -8.4%
Covered Lines: 23893
Relevant Lines: 30745
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Panaetius @coveralls