Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly remove activities in workflow remove if catalog is corrupt #3729

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Panaetius
Copy link
Member

happened in a user project

@Panaetius Panaetius requested a review from a team as a code owner July 11, 2024 14:19
@Panaetius Panaetius enabled auto-merge (squash) July 11, 2024 14:42
@Panaetius Panaetius merged commit b2418a1 into develop Jul 11, 2024
27 of 30 checks passed
@Panaetius Panaetius deleted the fix-activity-removal branch July 11, 2024 14:47
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9893159899

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.3%) to 77.595%

Files with Coverage Reduction New Missed Lines %
renku/ui/cli/service.py 1 72.49%
renku/core/dataset/providers/dataverse.py 1 82.83%
renku/core/login.py 1 26.88%
renku/core/workflow/activity.py 1 76.04%
renku/ui/cli/init.py 1 95.42%
renku/core/util/git.py 5 74.17%
Totals Coverage Status
Change from base Build 9892840658: 0.3%
Covered Lines: 23855
Relevant Lines: 30743

💛 - Coveralls

Panaetius pushed a commit that referenced this pull request Jul 12, 2024
* fix: properly remove activities in workflow remove if catalog is corrupt (#3729)

* chore: release v2.9.4

* Update CHANGES.rst

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants