feat: added ice cream

[wiggle1000]

Adds a few flavors of ice cream, which is clearly a mandatory feature.

I have tried my best to keep it as clean and on-style as possible, but this is my first time working with Fabric and Kotlin, so I may have goofed up somewhere!

[Lignum]

Some minor syntactical concerns, most if not all of which should be fixed by the IntelliJ formatter. Not sure if this fits sc-goodies, but looks mergeable otherwise.

[wiggle1000]

Updated with syntax fixes. Sorry for the bracket mess haha, the C++ muscle memory is coming for my life.

In defense of the off-topicness of the feature, I have to admit that this isn't really a direct replacement for anything we had on SC2. A lot of the community members recently (as I'm sure you've seen) have been increasingly interested in adding food items. I was thinking that this would be a fun, vanilla-style, and lightweight way to scratch a bit of that itch while people potentially implement more complex food systems.

[penguinencounter]

nit: should there be an underscore between ice and cream because it's two words?

Suggested change

	val iceCreamVanilla = rIceCreamItem("icecream_vanilla")
	val iceCreamChocolate = rIceCreamItem("icecream_chocolate")
	val iceCreamSweetBerry = rIceCreamItem("icecream_sweetberry")
	val iceCreamNeapolitan = rIceCreamItem("icecream_neapolitan")
	val iceCreamSpruce = rIceCreamItem("icecream_spruce")
	val iceCreamMelon = rIceCreamItem("icecream_melon")
	val iceCreamBeetroot = rIceCreamItem("icecream_beetroot")
	// This is a bit messy, but a much simpler way to have the sundae be worth more food
	val iceCreamSundae = rItem("icecream_sundae", IceCreamItem(itemSettings()
	val iceCreamVanilla = rIceCreamItem("ice_cream_vanilla")
	val iceCreamChocolate = rIceCreamItem("ice_cream_chocolate")
	val iceCreamSweetBerry = rIceCreamItem("ice_cream_sweetberry")
	val iceCreamNeapolitan = rIceCreamItem("ice_cream_neapolitan")
	val iceCreamSpruce = rIceCreamItem("ice_cream_spruce")
	val iceCreamMelon = rIceCreamItem("ice_cream_melon")
	val iceCreamBeetroot = rIceCreamItem("ice_cream_beetroot")
	// This is a bit messy, but a much simpler way to have the sundae be worth more food
	val iceCreamSundae = rItem("ice_cream_sundae", IceCreamItem(itemSettings()

[wiggle1000]

Oh yeah, this is probably more proper! I didn't think about it that hard to be honest.

[Lemmmy]

Thanks very much for taking the time to submit this PR; did you make the sprites yourself?

A lot of the community members recently (as I'm sure you've seen) have been increasingly interested in adding food items.

I sat on these PRs for a while because I believed at the time that it was just a fad. Out of the ones that came up, this one is the most likely to get merged, but I'm still not sure why it should be, or what value it would add.

I'm all down for a bit of silly fun, and accepting one or two food PRs might be relatively harmless, a bit of the unique SwitchCraft character. But, I don't really want to set a precedent here, potentially opening the floodgates to dozens of low-quality, single-file food PRs. At what point does it start becoming ridiculous? We already have one useless food item: popcorn… I'm aware that #4 is still sitting around.

[wiggle1000]

Thanks very much for taking the time to submit this PR; did you make the sprites yourself?

I did! There shouldn't be any licensing issues.

But, I don't really want to set a precedent here, potentially opening the floodgates to dozens of low-quality, single-file food PRs. At what point does it start becoming ridiculous?

This is definitely an important consideration. I personally think it might be best to just judge it on a per-request basis. The community is pretty small, so I can't imagine it getting out of hand very easily.

We already have one useless food item

I disagree! Silly fun is the beating heart of Switchcraft!! Most things can be done with Computercraft and the 3d printers, but still not everything. If there were printer flags for more types of items (food, sit-on-able, etc), I think it would reduce the need for features like these, but that's a totally different conversation about a separate mod. Haha!

P.S. Sorry for the late reply!! I didn't get the notification for some reason