Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init form provider #793

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Init form provider #793

merged 1 commit into from
Nov 23, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 23, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner November 23, 2023 11:44
loic425
loic425 commented Nov 23, 2023
View reviewed changes
src/Component/Tests/Symfony/EventListener/FormListenerTest.php
@@ -75,16 +75,10 @@ public function it_handles_forms(): void
$request->attributes = $attributes;
$request->getRequestFormat()->willReturn('html');

$attributes->get('_route')->willReturn('app_dummy_show');
Copy link
Member Author

@loic425 loic425 Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed a lot of non-necessary code in this test class, but in the end, this form listener and its PHPUnit test class will be removed.

@lchrusciel lchrusciel merged commit 7f9f07a into Sylius:1.11 Nov 23, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @lchrusciel @diimpp