-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AWS bedrock integration #289
Open
ajithvcoder
wants to merge
12
commits into
SylphAI-Inc:main
Choose a base branch
from
ajithvcoder:feature_bedrock_improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve AWS bedrock integration #289
ajithvcoder
wants to merge
12
commits into
SylphAI-Inc:main
from
ajithvcoder:feature_bedrock_improve
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for aws bedrock integration
was literally about to make a PR to fix the list model method. Looks like you beat me to it. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aws_profile_name
andaws_region_name
list_models()
and added support to pass arguments for specific model fetchingconvert_inputs_to_api_kwargs()
to acceptmodel
asmodelId
andmax_tokens
asmaxTokens
internallyinferenceConfig
andadditionalModelRequestFields
aws_bedrock.rst
file for documentationtutorials\bedrock_client_simple_qa.py
for showing usage exampletutorials\generator_all_providers.py
Fixes #283
Before submitting
Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline? yes
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary) Yes
Did you write any new necessary tests? (not for typos and docs) Yes i have added mock tests and
tutorials\bedrock_client_simple_qa.py
Did you verify new and existing tests pass locally with your changes? Yes
Did you list all the breaking changes introduced by this pull request? There is no breaking changes