Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Meshes.jl test #119

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Disable Meshes.jl test #119

merged 1 commit into from
Mar 2, 2024

Conversation

MilesCranmer
Copy link
Member

@MilesCranmer MilesCranmer commented Mar 2, 2024

Meshes.jl compatibility is currently broken due to a design issue recently introduced in that package, see: #118. Once that package amend this issue we can turn this test back on, but I am averse to having ❌ show up on our tests if there isn't actually an issue on our side...

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Benchmark Results

main 31b02b5... main/31b02b5aa26b93...
Quantity/creation/Quantity(x) 3.41 ± 0.011 ns 2.79 ± 0 ns 1.22
Quantity/creation/Quantity(x, length=y) 3.11 ± 0.01 ns 3.41 ± 0.01 ns 0.912
Quantity/with_numbers/*real 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_numbers/^int 8.05 ± 2.2 ns 8.04 ± 1.9 ns 1
Quantity/with_numbers/^int * real 8.67 ± 2.2 ns 8.36 ± 1.9 ns 1.04
Quantity/with_quantity/+y 4.04 ± 0.001 ns 4.04 ± 0.001 ns 1
Quantity/with_quantity//y 3.42 ± 0.011 ns 3.11 ± 0.001 ns 1.1
Quantity/with_self/dimension 3.11 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_self/inv 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1
Quantity/with_self/ustrip 2.79 ± 0.01 ns 2.79 ± 0.22 ns 1
QuantityArray/broadcasting/multi_array_of_quantities 0.145 ± 0.00073 ms 0.146 ± 0.00086 ms 0.997
QuantityArray/broadcasting/multi_normal_array 0.053 ± 0.0002 ms 0.0528 ± 0.0041 ms 1
QuantityArray/broadcasting/multi_quantity_array 0.155 ± 0.00067 ms 0.158 ± 0.00066 ms 0.983
QuantityArray/broadcasting/x^2_array_of_quantities 22.7 ± 1.3 μs 22.2 ± 1.3 μs 1.02
QuantityArray/broadcasting/x^2_normal_array 4.28 ± 0.82 μs 4.23 ± 0.93 μs 1.01
QuantityArray/broadcasting/x^2_quantity_array 6.97 ± 0.22 μs 6.85 ± 0.48 μs 1.02
QuantityArray/broadcasting/x^4_array_of_quantities 0.0787 ± 0.00054 ms 0.0786 ± 0.00048 ms 1
QuantityArray/broadcasting/x^4_normal_array 0.0467 ± 0.00024 ms 0.0497 ± 0.00016 ms 0.939
QuantityArray/broadcasting/x^4_quantity_array 0.0515 ± 0.0031 ms 0.0499 ± 0.00016 ms 1.03
time_to_load 0.129 ± 0.0032 s 0.126 ± 0.003 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit b90e55c into main Mar 2, 2024
7 checks passed
@MilesCranmer MilesCranmer deleted the fix-meshes branch March 2, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant