-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 7 #274
Allow Symfony 7 #274
Conversation
When is this request expected to be approved? Symfony 7 is out, and this bundle blocks the update |
No cooe reviews of it yet... feel free to give a review to speed up the process :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
Thank you Victor! |
Hello! Tried to install the bundle on a fresh symfony 7 installation and it blocked the make:migration with an error: [Semantical Error] The class "Doctrine\ORM\Mapping\Column" is not annotated with @annotation. Annotations are not supported anymore in Symfony 7 and even if old annotations were removed from the entity ResetPasswordRequest.php. It's still present in the trait file. Remove old annotations from ResetPasswordRequestTrait.php in vendor/symfonycasts/reset-password-bundle/src/Model/ResetPasswordRequestTrait.php did the trick to permit the make:migration |
No description provided.