Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new bundle structure #312

Merged
merged 3 commits into from
Apr 27, 2024
Merged

use new bundle structure #312

merged 3 commits into from
Apr 27, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 17, 2024 •
edited
Loading

wip - see symfony/symfony-docs#19793

  • double check the structure against https://symfony.com/doc/current/bundles/best_practices.html && the PR mentioned above
  • test locally
  • test in linked app on linux
  • test in linked app on macos
  • test again...
  • add test to ensure if lifetime is changed in userland - the new value is used in the helper... this may already be a thing

Move translations to root/translations in separate PR - we'll sync the translations with verify-email at the same time.

@jrushlow jrushlow added the Minor Minor Enhancement label Apr 17, 2024
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Apr 26, 2024
@jrushlow jrushlow added this to the 2.x - Pre-release milestone Apr 26, 2024
@jrushlow jrushlow mentioned this pull request Apr 26, 2024
Open
20 tasks
bocharsky-bw
bocharsky-bw approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@jrushlow jrushlow merged commit 23c7cb4 into SymfonyCasts:2.x Apr 27, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/2.x/new-bundle-structure branch April 27, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
Minor Minor Enhancement Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
2.x - Pre-release
Development

Successfully merging this pull request may close these issues.
2 participants
@jrushlow @bocharsky-bw