Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for phpunit 11 #79

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

wickedOne
Copy link
Contributor

allow installation of phpunit 11
removed conflict section as well as it won't install phpunit <9.6 anyway?

@mbabker
Copy link
Contributor

mbabker commented Feb 22, 2024

removed conflict section as well as it won't install phpunit <9.6 anyway?

The conflict section would be what blocks installing this package alongside unsupported PHPUnit versions in downstream apps/packages. Realistically, I'd say the phpunit/phpunit dependency should be in the require section instead of require-dev since this is a PHPUnit extension of sorts, but for packages where you have an optional dependency not in the require section of the Composer manifest, using the conflict section creates a functionally equivalent result.

@Spomky
Copy link

Spomky commented Jun 16, 2024

Hi,

@matthiasnoback do you think this PR is ready and could be merged/tagged?

@wickedOne
Copy link
Contributor Author

@Spomky matthiaas is no longer involved in these repos (or so i learned :-) )

ping @Nyholm

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbabker If you are happy, feel free to merge.

@mbabker
Copy link
Contributor

mbabker commented Jun 17, 2024

@mbabker If you are happy, feel free to merge.

I would, but I don't have merge rights here. I'm just one of those drive-by contributor types 😅

@Nyholm
Copy link
Member

Nyholm commented Jun 17, 2024

Oh. Sorry =)

@Nyholm Nyholm merged commit 59f4d3b into SymfonyTest:master Jun 17, 2024
13 checks passed
@Spomky
Copy link

Spomky commented Jun 22, 2024

Many thanks @Nyholm 👍🏼
Works fine when using the master branch. Waiting for it to be tagged.
Regards.

@wickedOne wickedOne deleted the phpunit-11 branch June 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants