Allow phpunit 11 #84
Closed
Allow phpunit 11 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the installation of phpunit 11 for running the tests in this library.
I've run the tests locally on PHP 8.1, 8.2 and 8.3.
It is giving some deprecation warnings when phpunit 11 is installed, but no errors are reported.
Also adjusts the conflict configuration to allow installation of this package along with phpunit 11.
I've installed this library, with this adjusted config, along with phpunit 11 in a project of my own and did not run into issues doing so. Although I'm not using everything from this library, it appears to be fine to use with phpunit 11.
I know there is already another pullrequest for phpunit 11, but that pull request changes how versions are handled. I think this works just fine.
Let me know if I need to adjust something else. Or of I need to leave the require-dev as is.