Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Althome #652

Merged
merged 5 commits into from
May 9, 2024
Merged

Althome #652

merged 5 commits into from
May 9, 2024

Conversation

danielfang97
Copy link
Contributor

added althome to theme, working on sbh2 local where you can click the top left logo and redirect to whatever you set as the alternate homepage

const errorMessages = error.response.data.details.map(
error => error.message
(err) => err.message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Seems like it should be error?

Copy link
Contributor

@cjmyers cjmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@danielfang97
Copy link
Contributor Author

I think chatgpt changed some syntax, and I didn't notice. I'll change it back. Thanks for catching it. You probably need to approve it first, and then I can make a new branch to change it since there's some other branches that's making it so I can't push it to Github.

@cjmyers
Copy link
Contributor

cjmyers commented May 9, 2024

Please be more careful with ChatGPT. I will approve this one now.

@cjmyers cjmyers merged commit ee66296 into main May 9, 2024
5 checks passed
@cjmyers cjmyers deleted the althome branch May 9, 2024 19:02
@cjmyers
Copy link
Contributor

cjmyers commented May 9, 2024

Merged by habit. Please get the fix in through another PR quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants