Skip to content

Commit

Permalink
Add TODO to remove hacky-ish workaround
Browse files Browse the repository at this point in the history
  • Loading branch information
InKryption committed Jan 22, 2025
1 parent 2867ffc commit 922a7bb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/rpc/server.zig
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ test Context {
defer blk: {
exit.store(true, .release);
// send a dummy request so that the serve thread will get the accept and observe `exit`.
// TODO(ink): we only issue interruptSelf for the basic work pool, and not the io_uring one,
// because for some reason that causes it to hang. this is kinda nasty and it would be
// nice for this to Just Work, however I suspect it may have something to do with the
// fact that it's the process sending itself a connection multiple times.
if (work_pool == .basic) interruptSelf(allocator, self_uri) catch |err| {
if (@errorReturnTrace()) |st| {
std.log.err("{s}\n{}", .{ @errorName(err), st });
Expand Down

0 comments on commit 922a7bb

Please sign in to comment.