Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to angular 9 #509

Merged
merged 26 commits into from
Mar 6, 2020
Merged

Update to angular 9 #509

merged 26 commits into from
Mar 6, 2020

Conversation

DanielHabenicht
Copy link
Collaborator

@DanielHabenicht DanielHabenicht commented Mar 3, 2020 •
edited
Loading

Faster Builds! (Just 76s!) (in the future also only one build instead of 2)
Smaller Files (~20%)
Better translation coming (just not yet, angular team still need time angular/angular-cli#16375)

Till then:

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Mar 4, 2020

🤯🤯 Angular 9

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

@DanielHabenicht
Copy link
Collaborator Author

@T-Systems-MMS/phonebook-developers would you take a look if everything is still working?

@DanielHabenicht DanielHabenicht requested review from Zeroks77 and mschwrdtnr and removed request for Zeroks77 March 5, 2020 10:02
@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Mar 5, 2020

image
found something :D
think he shouldnt be empty

@DanielHabenicht
Copy link
Collaborator Author

Thats not a problem of this PR but a general Problem. You can find the same problem in the main demo.

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

paule96
paule96 previously approved these changes Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@paule96 paule96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove empty lines. :) But the rest looks okay 👍

@DanielHabenicht
Copy link
Collaborator Author

@marcuskrahl Wenn du Zeit hast kannst du gerne einmal drüber schauen. Falls du ein paar Ratschläge für das updaten auf Angular 9 (insbesondere i18n) brauchst schreib mich einfach an.

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-509.demo-phonebook.me

@DanielHabenicht
Copy link
Collaborator Author

@Zeroks77 approve?

@marcuskrahl
Copy link
Collaborator

I had a look at every commit except for the one with 15k lines changed for localization.
Looks all good to me.

@DanielHabenicht DanielHabenicht merged commit a81b424 into master Mar 6, 2020
@mmsgithub-ci
Copy link
Collaborator

🎉 This PR is included in version 1.36.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@DanielHabenicht DanielHabenicht deleted the update-to-angular-9 branch April 12, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcuskrahl marcuskrahl marcuskrahl approved these changes

@paule96 paule96 paule96 approved these changes

@mschwrdtnr mschwrdtnr Awaiting requested review from mschwrdtnr

@Zeroks77 Zeroks77 Awaiting requested review from Zeroks77

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielHabenicht @mmsgithub-ci @Zeroks77 @marcuskrahl @paule96