Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): New Backend and authentication for Phonebook data. #7

Merged
merged 61 commits into from
Apr 7, 2020
Merged

feat(backend): New Backend and authentication for Phonebook data. #7

merged 61 commits into from
Apr 7, 2020

Conversation

paule96
Copy link
Collaborator

@paule96 paule96 commented Apr 5, 2019 •
edited
Loading

The following are the changes, most of them are breaking changes:

  • replace the json file with a real backend
    • the backend connects directly to a database
    • currently, it try to return the same stuff as the old JSON file
  • Open Source the backend
  • add authentification to the people data
    • currently, supported is WsFederation over Azure or ADFS (and tested)

There are some issues that currently are known:

  • the search for numbers is broken
  • the last hierarchy in the org structure isn't visible in any view
    • organigram
    • users supervisor
    • Users organigram information
  • after login the user is redirected to / and not to the path the redirection starts. (New Backend: user authenitcation flow #586 )
  • the picture backend asked for login
    • this will change soon because we plan to use the same auth like this backend.

But we must ship this because the old source is broken. (after more than 15 years!)
So let's

ship it gif

BREAKING CHANGE
closes #18
closes #271

@paule96
use ef for the connection to the database
1735af4 
- warning: we are now officell unstable because the oracle dependencie is beta...
@paule96
add some missing project files
d465a35
@paule96 paule96 added the feature An enhancement or a new functionality feature. label Apr 5, 2019
@paule96
Copy link
Collaborator Author

paule96 commented Apr 5, 2019

This pr is blocked by a missing build infrastructure! I add this later. @DanielHabenicht we must do some internal discussions about this...

DanielHabenicht
DanielHabenicht previously approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@DanielHabenicht DanielHabenicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment it looks good! But we can add swashbuckle later if you want.

Phonebook.Source.PeopleSoft/src/Phonebook.Source.PeopleSoft/Controllers/BuildingController.cs Show resolved Hide resolved
@paule96 paule96 added this to the New backend for Phonebook milestone Jun 23, 2019
@paule96
Copy link
Collaborator Author

paule96 commented Jun 23, 2019

Good news @DanielHabenicht : This PR will continue on Monday :)

@DanielHabenicht DanielHabenicht mentioned this pull request Aug 8, 2019
Open
3 tasks
@paule96
now we get relational data from the peoplesoft backend
9778930
@paule96
cleanup dbcontext
84913d4
@paule96
fixing database changes
fcd985e
@paule96
rewrite queries and remove newtonsoft
ec4d095 
- improve performance
- beginn removing cycle refs
- enabled query errors if client evaluation is need
- endable usersecrets
@paule96
Copy link
Collaborator Author

paule96 commented Oct 2, 2019

think about query caching with:

https://github.com/VahidN/EFSecondLevelCache.Core
or this:

https://github.com/SteffenMangold/EntityFrameworkCore.Cacheable/

things that are also todo is to add maybe OData or something like this to allow querying data.

@DanielHabenicht
Copy link
Collaborator

I think just provide the bare minimum for the first PR. Querying Data is for a later version as we already discussed.

@paule96
Copy link
Collaborator Author

paule96 commented Oct 7, 2019

Okay, @DanielHabenicht and @mschwrdtnr, I have e-mailed you the current JSON result of the API, so you can check if you missing something. The result for a dataset of 2000 employees has a response time of 500ms. If this is to slow I must find a way to cache it.

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-7.demo-phonebook.me

@paule96
Copy link
Collaborator Author

paule96 commented Apr 6, 2020

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paule96
Copy link
Collaborator Author

paule96 commented Apr 6, 2020

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paule96
Copy link
Collaborator Author

paule96 commented Apr 6, 2020

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-7.demo-phonebook.me

@paule96
Copy link
Collaborator Author

paule96 commented Apr 6, 2020

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-7.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-7.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-7.demo-phonebook.me

@paule96
Copy link
Collaborator Author

paule96 commented Apr 7, 2020

@T-Systems-MMS/phonebook-developers please look at this. I will merge this at 7pm. If you find any issues that is your last chance ;)

@DanielHabenicht
Copy link
Collaborator

ship it gif

@paule96
Copy link
Collaborator Author

paule96 commented Apr 7, 2020

Can we hack img tags in the Release Notes message? :D I wan't clippy in the release notes :D

@paule96 paule96 changed the title First real connection to the Datasource for our human data feat(backend) New Backend and authentication for Phonebook data. Apr 7, 2020
@DanielHabenicht
Copy link
Collaborator

Please add before the "closes" the literal "BREAKING CHANGE" otherwise it won't get picked up by semantic release.

@paule96 paule96 changed the title feat(backend) New Backend and authentication for Phonebook data. feat(backend): New Backend and authentication for Phonebook data. Apr 7, 2020
@paule96 paule96 merged commit bdbc898 into master Apr 7, 2020
@paule96 paule96 deleted the use_EF_for_oracle_DB branch April 7, 2020 17:05
@mmsgithub-ci
Copy link
Collaborator

🎉 This PR is included in version 1.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHabenicht DanielHabenicht DanielHabenicht left review comments

Assignees

@paule96 paule96

@DanielHabenicht DanielHabenicht

Labels
feature An enhancement or a new functionality feature. released
Projects
None yet
Milestone
New backend for Phonebook
Development

Successfully merging this pull request may close these issues.

Basic Auth Add build for Phonebook.Source.PeopleSoft
4 participants
@paule96 @DanielHabenicht @Zeroks77 @mmsgithub-ci