-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix query to filter on effective location #381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rhundal7
commented
Jun 24, 2024
•
edited
Loading
edited
- PR for issue Books Checked Out By Call Number should filter on effective location name #378
- Earlier I was setting the locationNames array to either get populated from the front end or set it to empty array and based my logic on that which was overcomplicated. I now changed it slightly. If the user selects all (more than allowed selections), in the frontend, it de-selects all selections, shows message to user. If the user still submits the form, it passes an empty array to backend, processes it (the scenario of everything) same like the scenario of nothing selected and returns the respective results. If the user selects some options, it passes that populated array to the backend and the respective where clause gets executed giving the result.
rmathew1011
requested changes
Jul 1, 2024
Dbreck-TAMU
reviewed
Jul 1, 2024
Dbreck-TAMU
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 1, 2024
wwtamu
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to get variables using the execution context, they are already available in the JavaScript scope.
wwtamu
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 1, 2024
wwtamu
reviewed
Jul 2, 2024
Co-authored-by: William Welling <[email protected]>
…istry into folio-sprint-18-issue-378
kaladay
requested changes
Jul 2, 2024
Co-authored-by: Kevin Day <[email protected]>
Co-authored-by: Kevin Day <[email protected]>
Co-authored-by: Kevin Day <[email protected]>
Co-authored-by: Kevin Day <[email protected]>
kaladay
approved these changes
Jul 2, 2024
wwtamu
approved these changes
Jul 2, 2024
rmathew1011
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.