Issue 302: Switch from Nashorn to GraalVM for Javascript execution. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions provided by issue are applied as-is with no observed problems.
kaladay
force-pushed
the
302-nashorn_to_graalvm
branch
from
1346044 to
f2f74c0
Compare
This dependency is also required:
```
<dependency>
<groupId>org.graalvm.js</groupId>
<artifactId>js-scriptengine</artifactId>
<version>22.3.3</version>
</dependency>
```
The following arning is observed:
```
[engine] WARNING: The polyglot context is using an implementation that does not support runtime compilation.
The guest application code will therefore be executed in interpreted mode only.
Execution only in interpreted mode will strongly impact the guest application performance.
For more information on using GraalVM see https://www.graalvm.org/java/quickstart/.
To disable this warning the '--engine.WarnInterpreterOnly=false' option or use the '-Dpolyglot.engine.WarnInterpreterOnly=false' system property.
[engine] WARNING: The polyglot context is using an implementation that does not support runtime compilation.
The guest application code will therefore be executed in interpreted mode only.
Execution only in interpreted mode will strongly impact the guest application performance.
For more information on using GraalVM see https://www.graalvm.org/java/quickstart/.
To disable this warning the '--engine.WarnInterpreterOnly=false' option or use the '-Dpolyglot.engine.WarnInterpreterOnly=false' system property.
```
The configuration file appears to be case sensitive.
Use `Graal.js` with an upper case `G` rather than a lower case `g`.
kaladay
requested review from
jsavell,
rmathew1011,
wwtamu,
Dbreck-TAMU and
qtamu
rhundal7
approved these changes
Oct 19, 2023
wwtamu
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves TAMULib/fw-registry#302
In addition to information provided on the issue, this dependency is also required:
The configuration file appears to be case sensitive.
Use
Graal.jswith an upper caseGrather than a lower caseg.The following warning is observed:
When JS processing errors happen, this gets shown:
see: https://forum.camunda.io/t/console-filling-with-graalvm-warnings-when-using-in-process-scripting/31812/2
see: https://docs.camunda.org/manual/7.19/user-guide/process-engine/scripting/#custom-scriptengineresolver