Filter field crashes undefined #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults.
The `view.utility.ts` has this block of code:
```
const getFilterField = (collectionView: CollectionView, actualFilter: Filter): string => {
return collectionView.facets.find(f => f.field === actualFilter.field).name;
};
```
That code assumes that the facet will always have a correct find.
So, it has a NULL/undefined error when .name is not found.
Then the entire page/site crashes and is unusable when this happens.
An easy fix is just to use the `?.` instead of `.`.
wwtamu
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The filterField() crashes on undefined when the find() returns no results.
The
view.utility.tshas this block of code:That code assumes that the facet will always have a correct find.
So, it has a NULL/undefined error when .name is not found.
Then the entire page/site crashes and is unusable when this happens.
An easy fix is just to use the
?.instead of..Type of change
Testing Procedures
Manual inspection and testing.