fix(webstorm): fix ts type prompt #563
Open
+2,811
−5,562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweijie0812
requested review from
Copilot
and removed request for
chaishi,
uyarn and
anlyyao
There was a problem hiding this comment.
PR Overview
This pull request fixes type formatting issues for the WebStorm environment by enhancing how TypeScript types are derived in the code.
- Added export of formatType in packages/scripts/types/index.js
- Modified packages/scripts/helper/index.js to compute and use formatted types via the new formatType function
Reviewed Changes
| File | Description |
|---|---|
| packages/scripts/types/index.js | Exported formatType to be used by helper functions |
| packages/scripts/helper/index.js | Updated type handling to use formatType's result for formatting |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/scripts/helper/index.js:118
- The formatType function may return a primitive type (api.type) instead of an object with a 'type' property, causing rType.type to be undefined. Consider ensuring that formatType consistently returns an object with a 'type' property, or adjust the usage accordingly.
type: rType ? rType.type : api.field_type_text,
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue 端 独立定义Typography 子组件
TypographyText
TypographyTitle
TypographyParagraph