Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding secure tag to cookie #12522

Closed
wants to merge 2 commits into from
Closed

Adding secure tag to cookie #12522

wants to merge 2 commits into from

Conversation

Luanmq
Copy link

@Luanmq Luanmq commented Jul 19, 2023

Fixed security hotspot related to creating a cookie without the secure flag. To learn more about this issue visit: OWASP

@github-actions
Copy link

Hi @Luanmq, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@wkurniawan07
Copy link
Member

cookie.setSecure(!Config.IS_DEV_SERVER);
Secure cookie flag has been set in here.

Closing as the change is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants