Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Add composite index for data migration #13057

Merged
merged 3 commits into from
Apr 19, 2024
Merged

[#12048] Add composite index for data migration #13057

merged 3 commits into from
Apr 19, 2024

Conversation

marquestye
Copy link
Contributor

Part of #12048

Outline of Solution

  • Added composite indexes for Course entity in index.yaml
  • Added IndexCourseFields script

@marquestye marquestye added the s.ToReview The PR is waiting for review(s) label Apr 18, 2024
@marquestye marquestye self-assigned this Apr 18, 2024
FergusMok
FergusMok approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the time to test this!

@NicolasCwy NicolasCwy merged commit 498efdc into TEAMMATES:master Apr 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FergusMok FergusMok FergusMok approved these changes

@NicolasCwy NicolasCwy NicolasCwy approved these changes

@yuanxi1 yuanxi1 Awaiting requested review from yuanxi1

@mingyuanc mingyuanc Awaiting requested review from mingyuanc

Assignees

@marquestye marquestye

Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquestye @FergusMok @NicolasCwy