Add infunnel wrapper, simplify code generation #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
approved these changes
Jul 22, 2024
|
You already have one CI run for code generation--do you mean run code generation for every build on every combination of versions and platforms? I'm not convinced that would be a good idea. |
Nope. I forgot I already did that :-/ |
|
@efiring are you OK with a new release? I can do that later today/tomorrow. |
|
Yes, a release would be fine, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the infunnel function, with its int return, required enough change that I took the opportunity to re-write some of the code generation functions.