Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues in factorial, oddeve, and sum. #16

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

usefmahmud
Copy link
Contributor

@usefmahmud usefmahmud commented Nov 25, 2024

Solved issues #5, #7, #8.

  • In factorial I changed the initial value of fact to 1.
  • In sum added the variable c to the input statement.
  • In oddeve used the mod % instead of division by 2

@usefmahmud
Copy link
Contributor Author

@AmanNegi
Can you please accept the PR?

@AmanNegi
Copy link
Collaborator

Hey @usefmahmud, thanks for the contribution ✨🙌

I'd love to know how did you explore about this repository.

@usefmahmud
Copy link
Contributor Author

I found it across https://goodfirstissues.com. And really thank you for this initiative

@AmanNegi
Copy link
Collaborator

Great work @usefmahmud. Thanks for the contribution. 🙌🌟

A suggestion from me would be to keep a meaningful name for each branch. Also it's a good idea to solve one issue using one PR(not always though, if the issues are related it's fine).

Again thanks, and I hope you were able to build some confidence. Cheers 🥂🥳

@AmanNegi AmanNegi merged commit 96ac1c4 into TFUGJalandhar:main Nov 26, 2024
@usefmahmud
Copy link
Contributor Author

I will keep it in mind. Thanks for you feedback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants