fix inspector for newer WPEWebKit & WPELauncher combination #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, the patch can be changed as well. |
|
Good to know. We never worked with the remote inspector in this project. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch that ports WPELauncher from the old (stable) branch creates a
/usr/bin/wpescript with the environment variable for enabling the remote inspector that only works with the older WPEWebKit.buildroot-webkit/0001-port-wpelauncher-from-stable.patch
Line 145 in cb30ee6
The new WPEWebKit with WPELauncher works only if this env var is named
WEBKIT_LEGACY_INSPECTOR_SERVER.See WebPlatformForEmbedded/WPEWebKit#549 (comment)