-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPI shared memory #14
Open
hmenke
wants to merge
6
commits into
TRIQS:unstable
Choose a base branch
from
hmenke:shm
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92e2e2b
to
1738e29
Compare
hmenke
commented
Oct 9, 2023
hmenke
commented
Aug 16, 2024
hmenke
commented
Aug 16, 2024
hmenke
commented
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this non-MPI compatible?
hmenke
commented
Aug 16, 2024
This adds a new abstraction for MPI_Group to be able to use the post-start-complete-wait RMA cycle. Also adds documentation and more tests. Co-authored-by: Mohamed Aziz Bellaaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests were run with multiple nodes and different number of slots on each node:
Some ideas:
MPI allocatorSimilar to
std::allocator
implement ashared_allocator
and adistributed_shared_allocator
, such that one can use e.g.std::vector<double, mpi::shared_allocator<double>>
Questions:
split_shared()
on the default communicator, but for distributed shared memory there needs to be internode communication and that is not easily guessed from the default communicator. Maybe a global hash table with allocation information is needed?On top of that, for distributed shared memory access must be fenced and broadcasted between nodes. That's not so easy to abstract away.