Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the monitor class #20

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

Thoemi09
Copy link
Contributor

@Thoemi09 Thoemi09 commented Sep 9, 2024

  • added a duplicate and a free function to the mpi::communicator class
  • generalized the mpi::monitor class to handle general events instead of errors
    • renamed member functions
    • allow to check if at least one event has occurred on some process (some_event_occurred()) or if an event has occurred on all processes (all_events_occurred())
    • use the given communicator instead of MPI_COMM_WORLD
    • make root a member variable which defaults to 0

Copy link
Member

@Wentzell Wentzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Thoemi09 for this generalization and for incorporating the first round of feedback we discussed. See additional suggestions below.

doc/ex2.md Outdated Show resolved Hide resolved
c++/mpi/monitor.hpp Outdated Show resolved Hide resolved
c++/mpi/monitor.hpp Outdated Show resolved Hide resolved
@Wentzell Wentzell merged commit 86d6d7a into TRIQS:unstable Sep 12, 2024
4 checks passed
@Thoemi09 Thoemi09 deleted the DEV_MONITOR branch September 12, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants