Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy admins when copying course #1079

Merged
merged 2 commits into from
Jul 12, 2023
Merged

copy admins when copying course #1079

merged 2 commits into from
Jul 12, 2023

Conversation

joschahenningsen
Copy link
Member

Motivation and Context

When copying a course, we want to retain the admins of the course. Likely one of them copied the course in the first place.

Description

When copying a course we iterate over the admins of the previous course and insert them into the database for the new course

Steps for Testing

Prerequisites:

  • 1 course
  • 1 lectuer
  1. Make sure you are logged in as a lecturer and copy a course you are admin of.
  2. Check that you are now admin of the newly created course.

@github-actions
Copy link

Your Testserver will be ready at https://1079.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@MatthiasReumann MatthiasReumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks 👍🏻

I wonder if a feature to "shallow"-copy VODs of a previous semester to another would make sense. For example, if something fails (worker, etc.) dramatically. Could potentially also save some storage space because re-uploads from previous semesters would become redundant 🤔

@joschahenningsen joschahenningsen merged commit ede41ef into dev Jul 12, 2023
@joschahenningsen joschahenningsen deleted the course-copy-fixes branch July 12, 2023 07:30
@joschahenningsen
Copy link
Member Author

I wonder if a feature to "shallow"-copy VODs of a previous semester to another would make sense.

Yes, great idea! Will work on that :)

@alexanderstephan
Copy link
Collaborator

I just was about to create an issue for this since I noticed it for the "C-Vorkurs". Thanks for the fix!

SebiWrn pushed a commit that referenced this pull request May 7, 2024
* copy admins when copying course

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants