New Start Page Updates #1095
New Start Page Updates #1095
Conversation
|
Your Testserver will be ready at https://1095.test.live.mm.rbg.tum.de in a few minutes. Logins
|
MatthiasReumann
requested review from
alexanderstephan,
joschahenningsen and
mono424
branding/thumb-fallback.png
Outdated
There was a problem hiding this comment.
Looks nice, did you design this?
There was a problem hiding this comment.
Unfortunately not. It is one of the corporate design Zoom backgrounds 😅
There was a problem hiding this comment.
Okay, but since we're also a TUM internal service, this is fine, I guess. Although I am not 100% sure about the licensing implications here.
| @@ -303,13 +291,16 @@ func sortCourses(courses []model.Course) { | |||
| } | |||
|
|
|||
| func (r coursesRoutes) getCourseBySlug(c *gin.Context) { | |||
There was a problem hiding this comment.
I've only noticed that I can't view public courses anymore when not logged-in.
This appears to be introduced by this PR if I am not mistaken (works on dev).
E.g., I can see https://1114.test.live.mm.rbg.tum.de/?year=2022&term=W&slug=t2&view=3, but not https://1095.test.live.mm.rbg.tum.de/. Seems like a permission issue which keeps it from loading at all. 🤔 (Happens both on Chrome and Firefox.) Maybe related to these changes here?
There was a problem hiding this comment.
Not related to these changes but still good catch! Thanks for pointing out. Should be fixed now.
There was a problem hiding this comment.
Okay, just was curious. Thanks for the quick fix, works now again!
Changes: - Enlarge logo - Add visibility checks (Redirect on Unauthorized) - Resolve #1089 (Add back the eye symbol) - Resolve #1111 (`py-2` -> `py-px`) - Resolve #1110 (Use locale setting to determine date format) - Resolve #1112 (See Screenshot) - Resolve #1116 (Remove year and term queries of pinned API) - Resolve #1106 (Add keys to storage) - Resolve #1108 (Add `isAdmin` to CourseDTO) - Resolve #1115 (Add `SetSignedPlaylists` before adding streams to DTO) - Resolve #1109 (Add [this](https://portal.mytum.de/corporatedesign/vorlagen/index_videokonferenzen/hintergruende_videokonferenzen/TUM-Logos-Tapete-hellblau.png) fallback thumbnail to assets and branding configuration)
Description
py-2->py-px)isAdminto CourseDTO)SetSignedPlaylistsbefore adding streams to DTO)Screenshots