Improve semester selection in home sidebar #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosefSchoenberger
force-pushed
the
enh/better-semester-selection
branch
2 times, most recently
from
ca532b4
to
e0a0080
Compare
JosefSchoenberger
force-pushed
the
enh/better-semester-selection
branch
from
e0a0080
to
4460a79
Compare
joschahenningsen
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Personally, I'd go for something like 2023/24 like here https://tu-film.de/programm, but I have no strong opinion on this. @alexanderstephan feel free to merge whenever fine for you
Sure, why not? |
JosefSchoenberger
force-pushed
the
enh/better-semester-selection
branch
from
dedfff3
to
29be50b
Compare
alexanderstephan
approved these changes
Aug 23, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
Adds /20xx to all winter semesters in the semester selection sidebar. Also increases bottom margin on the currently selected semester.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves #1138.
Description
Adds
/20xxto all winter semesters in the semester selection sidebar.Also increases bottom margin on the currently selected semester.
Steps for Testing
Screenshots