Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/refactor course sections #1156

Merged
merged 71 commits into from
Sep 30, 2023

Conversation

mono424
Copy link
Collaborator

@mono424 mono424 commented Sep 11, 2023

Motivation and Context

#1137 made the code shorter and brought it in a better and reactive structure. The videosections have been following an own update cycle. It would be nice to have one united update cycle experience for a lecture. Giving the user the opportunity to discard or save all changed data by one button.

Description

Integrated the course section editing to the lecture edit section.

Steps for Testing

  • Go to course management Page
  • Open a course
  • Edit a lecture
  • Add / Delete / Change Video Sections
  • Test: Discard & Save
  • Reload and check if data is persistent

Screenshots

Super reactive UX with change-set & DataProviders

Bildschirmaufnahme.2023-09-15.um.17.43.22.mov

Complex reactive validation

Bildschirmaufnahme.2023-09-15.um.20.39.54.mov

also fixes #1178

@mono424 mono424 marked this pull request as ready for review September 15, 2023 18:41
@joschahenningsen
Copy link
Member

merging #1137 created a few conflicts, can you merge them?

@joschahenningsen joschahenningsen merged commit bad8f2c into dev Sep 30, 2023
7 checks passed
@joschahenningsen joschahenningsen deleted the improvement/refactor-course-sections branch September 30, 2023 12:25
Mjaethers pushed a commit to Mjaethers/gocast that referenced this pull request Nov 3, 2023
* started wit hrefactor of course management

* add dao & route

* update route

* started wit hfetching

* Add changeset abstraction

* cleanup file

* remove get all streams again, as there is AdminJson method

* Its rendering

* further dev :S

* added some directive

* little fixes

* ...

* ... no idea...

* right path i guess

* changeset working except video sections

* fix discard files

* save from laptop

* Add changeset doku

* make private works like charm

* changing works pretty well

* add video upload

* add series update

* ported transcoding

* add readme and lecture hall select

* more description

* simplified lecture hall set

* linter

* more fixes

* :)

* add attachments

* :)

* add video sections to admin streams

* main functionality

* using fetch wrtappers

* moved uploadFile and postFormData

* fix linteer

* Impl. Feedback

* add video sections to admin streams

* main functionality

* using fetch wrtappers

* moved uploadFile and postFormData

* version workers with tag (TUM-Dev#1157)

* fix linteer

* fix delete lecture

* reenable page reload on create

* some linter fixes

* fix merge complications

* fix changeset; adding onchange listener

* fixed adding sections

* added directives

* fix typo

* improved directives

* design improvement

* fixed creating and deleting

* add sections fixed

* cleanup

* :)

* fix alpine js error issues

* remoev console log

* nested :)

* remove console log

* lint-fix

* fix admin.LectureList initialisation in settings tab

---------

Co-authored-by: Joscha Henningsen <[email protected]>
Co-authored-by: Joscha Henningsen <[email protected]>
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* started wit hrefactor of course management

* add dao & route

* update route

* started wit hfetching

* Add changeset abstraction

* cleanup file

* remove get all streams again, as there is AdminJson method

* Its rendering

* further dev :S

* added some directive

* little fixes

* ...

* ... no idea...

* right path i guess

* changeset working except video sections

* fix discard files

* save from laptop

* Add changeset doku

* make private works like charm

* changing works pretty well

* add video upload

* add series update

* ported transcoding

* add readme and lecture hall select

* more description

* simplified lecture hall set

* linter

* more fixes

* :)

* add attachments

* :)

* add video sections to admin streams

* main functionality

* using fetch wrtappers

* moved uploadFile and postFormData

* fix linteer

* Impl. Feedback

* add video sections to admin streams

* main functionality

* using fetch wrtappers

* moved uploadFile and postFormData

* version workers with tag (#1157)

* fix linteer

* fix delete lecture

* reenable page reload on create

* some linter fixes

* fix merge complications

* fix changeset; adding onchange listener

* fixed adding sections

* added directives

* fix typo

* improved directives

* design improvement

* fixed creating and deleting

* add sections fixed

* cleanup

* :)

* fix alpine js error issues

* remoev console log

* nested :)

* remove console log

* lint-fix

* fix admin.LectureList initialisation in settings tab

---------

Co-authored-by: Joscha Henningsen <[email protected]>
Co-authored-by: Joscha Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course setting cannot be saved
2 participants